From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Florian Fainelli <florian@openwrt.org>
Cc: Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
ralf@linux-mips.org, linux-mips@linux-mips.org
Subject: Re: [PATCH 4/5] MIPS: BCM63XX: add RNG driver platform_device stub
Date: Sat, 10 Dec 2011 18:46:49 +0400 [thread overview]
Message-ID: <4EE370D9.9090900@mvista.com> (raw)
In-Reply-To: <1323457270-16330-5-git-send-email-florian@openwrt.org>
Hello.
On 09-12-2011 23:01, Florian Fainelli wrote:
> Signed-off-by: Florian Fainelli<florian@openwrt.org>
[...]
> diff --git a/arch/mips/bcm63xx/dev-trng.c b/arch/mips/bcm63xx/dev-trng.c
> new file mode 100644
> index 0000000..19ccfbf
> --- /dev/null
> +++ b/arch/mips/bcm63xx/dev-trng.c
> @@ -0,0 +1,40 @@
[...]
> +static struct resource trng_resources[] = {
> + {
> + .start = -1, /* filled at runtime */
> + .end = -1, /* filled at runtime */
> + .flags = IORESOURCE_MEM,
> + },
> +};
> +
> +static struct platform_device bcm63xx_trng_device = {
> + .name = "bcm63xx-trng",
> + .id = 0,
Why not -1? Isn't there only single device of this sort?
WBR, Sergei
next prev parent reply other threads:[~2011-12-10 14:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-09 19:01 [PATCH 0/5] Broadcom BCM63xx RNG support Florian Fainelli
2011-12-09 19:01 ` [PATCH 1/5] MIPS: BCM63XX: fix BCM6368 IPSec clock bit Florian Fainelli
2011-12-09 19:01 ` [PATCH 2/5] MIPS: BCM63XX: add support for "ipsec" clock Florian Fainelli
2011-12-09 19:01 ` [PATCH 3/5] MIPS: BCM63XX: add TRNG peripheral definitions Florian Fainelli
2011-12-09 19:01 ` [PATCH 4/5] MIPS: BCM63XX: add RNG driver platform_device stub Florian Fainelli
2011-12-10 14:46 ` Sergei Shtylyov [this message]
2011-12-16 15:03 ` Florian Fainelli
2011-12-09 19:01 ` [PATCH 5/5] hw_random: add Broadcom BCM63xx RNG driver Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE370D9.9090900@mvista.com \
--to=sshtylyov@mvista.com \
--cc=florian@openwrt.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-mips@linux-mips.org \
--cc=mpm@selenic.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.