From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50506) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RZgmA-0005tA-OB for qemu-devel@nongnu.org; Sun, 11 Dec 2011 05:36:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RZgm8-00014B-Tf for qemu-devel@nongnu.org; Sun, 11 Dec 2011 05:36:58 -0500 Received: from fmmailgate01.web.de ([217.72.192.221]:45366) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RZgm8-00013e-FA for qemu-devel@nongnu.org; Sun, 11 Dec 2011 05:36:56 -0500 Received: from moweb002.kundenserver.de (moweb002.kundenserver.de [172.19.20.108]) by fmmailgate01.web.de (Postfix) with ESMTP id 37A2C1A441E0E for ; Sun, 11 Dec 2011 11:36:55 +0100 (CET) Message-ID: <4EE487C2.1040500@web.de> Date: Sun, 11 Dec 2011 11:36:50 +0100 From: Jan Kiszka MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig4F383E43977A20933B9F91E5" Subject: Re: [Qemu-devel] [PATCH 6/6] vga: compile cirrus_vga in hwlib List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig4F383E43977A20933B9F91E5 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2011-12-10 17:45, Blue Swirl wrote: > Remove target dependencies and compile Cirrus VGA in hwlib. >=20 > Signed-off-by: Blue Swirl > --- > Makefile.objs | 1 + > Makefile.target | 1 - > hw/cirrus_vga.c | 3 --- > 3 files changed, 1 insertions(+), 4 deletions(-) >=20 > diff --git a/Makefile.objs b/Makefile.objs > index 3a699ee..932c68a 100644 > --- a/Makefile.objs > +++ b/Makefile.objs > @@ -287,6 +287,7 @@ hw-obj-$(CONFIG_VGA_ISA) +=3D vga-isa.o > hw-obj-$(CONFIG_VGA_ISA_MM) +=3D vga-isa-mm.o > hw-obj-$(CONFIG_VMWARE_VGA) +=3D vmware_vga.o > hw-obj-$(CONFIG_VMMOUSE) +=3D vmmouse.o > +hw-obj-$(CONFIG_VGA_CIRRUS) +=3D cirrus_vga.o >=20 > hw-obj-$(CONFIG_RC4030) +=3D rc4030.o > hw-obj-$(CONFIG_DP8393X) +=3D dp8393x.o > diff --git a/Makefile.target b/Makefile.target > index 33df81f..00094b1 100644 > --- a/Makefile.target > +++ b/Makefile.target > @@ -206,7 +206,6 @@ obj-$(CONFIG_KVM) +=3D kvm.o kvm-all.o > obj-$(CONFIG_NO_KVM) +=3D kvm-stub.o > obj-y +=3D memory.o > obj-$(CONFIG_VGA) +=3D vga.o > -obj-$(CONFIG_VGA_CIRRUS) +=3D cirrus_vga.o > LIBS+=3D-lz >=20 > QEMU_CFLAGS +=3D $(VNC_TLS_CFLAGS) > diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c > index 846c8f5..0c86794 100644 > --- a/hw/cirrus_vga.c > +++ b/hw/cirrus_vga.c > @@ -618,7 +618,6 @@ static void > cirrus_invalidate_region(CirrusVGAState * s, int off_begin, > for (y =3D 0; y < lines; y++) { > off_cur =3D off_begin; > off_cur_end =3D (off_cur + bytesperline) & s->cirrus_addr_mask; > - off_cur &=3D TARGET_PAGE_MASK; Why is this redundant? Would be good to have the reasoning documented in the commit message. > memory_region_set_dirty(&s->vga.vram, off_cur, off_cur_end - o= ff_cur); > off_begin +=3D off_pitch; > } > @@ -1897,8 +1896,6 @@ static void cirrus_mmio_blt_write(CirrusVGAState > * s, unsigned address, > * > * write mode 4/5 > * > - * assume TARGET_PAGE_SIZE >=3D 16 > - * > ***************************************/ >=20 > static void cirrus_mem_writeb_mode4and5_8bpp(CirrusVGAState * s, Looking forward to seeing the second longest compilation step (after translate.o) pushed out of the hot path. Jan --------------enig4F383E43977A20933B9F91E5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk7kh8YACgkQitSsb3rl5xS6WwCgmuC98yx2JzFrZL49/uI6TnOt MMUAoL89C0fWKJT0tl/815ggyQ6uKEfy =7JEW -----END PGP SIGNATURE----- --------------enig4F383E43977A20933B9F91E5--