From: Lars-Peter Clausen <lars@metafoo.de>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, Michael.Hennerich@analog.com
Subject: Re: [PATCH 0/2] staging:iio: trigger owner field confusion cleanup.
Date: Sun, 11 Dec 2011 13:00:26 +0100 [thread overview]
Message-ID: <4EE49B5A.2000500@metafoo.de> (raw)
In-Reply-To: <1323531588-23293-1-git-send-email-jic23@kernel.org>
On 12/10/2011 04:39 PM, Jonathan Cameron wrote:
> This issue came to my attention whilst reviewing Maximes at91 patches.
> Anyhow, we have iio_trigger->owner and iio_trigger->ops->owner.
>
> The first was meant to have gone away.
> A couple of drivers don't provide iio_trigger->ops causing nastiness
> to happen when the trigger get or put occurs. Not seen in the wild
> as I don't have either of the two devices in question.
>
> Simple fix. Add the struture where missing and get rid of the owner field
> from the iio_trigger structure.
>
> Any comments?
>
> Jonathan
Looks good to me.
Both patches
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
>
> Jonathan Cameron (2):
> staging:iio: Make sure all triggers have a trigger_ops for the owner
> field.
> staging:iio: iio_trigger contains defunct owner field. Remove it.
>
> drivers/staging/iio/adc/ad7192.c | 7 +++++--
> drivers/staging/iio/adc/ad7793.c | 6 +++++-
> drivers/staging/iio/trigger.h | 2 --
> .../staging/iio/trigger/iio-trig-periodic-rtc.c | 1 -
> 4 files changed, 10 insertions(+), 6 deletions(-)
>
next prev parent reply other threads:[~2011-12-11 12:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-10 15:39 [PATCH 0/2] staging:iio: trigger owner field confusion cleanup Jonathan Cameron
2011-12-10 15:39 ` [PATCH 1/2] staging:iio: Make sure all triggers have a trigger_ops for the owner field Jonathan Cameron
2011-12-10 16:28 ` Jonathan Cameron
2011-12-10 15:39 ` [PATCH 2/2] staging:iio: iio_trigger contains defunct owner field. Remove it Jonathan Cameron
2011-12-11 12:00 ` Lars-Peter Clausen [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-12-14 20:49 [PATCH 0/2] staging:iio: trigger owner field confusion cleanup Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE49B5A.2000500@metafoo.de \
--to=lars@metafoo.de \
--cc=Michael.Hennerich@analog.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.