From mboxrd@z Thu Jan 1 00:00:00 1970 From: KOSAKI Motohiro Subject: Re: [PATCH 1/3] nitpick: make simple functions inline Date: Sun, 11 Dec 2011 13:55:55 -0500 Message-ID: <4EE4FCBB.9050600@gmail.com> References: <1323614738-7405-1-git-send-email-glommer@parallels.com> <1323614738-7405-3-git-send-email-glommer@parallels.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=EDGQhWN6E3GqHFS99BNU0YpDl5GQJnUx2v+SrmMZtT8=; b=PtaHSHwglLB7m8lpT7YFofATpaYBYynfq7Srr0RaU5flkpajZkE4nKmkAv8fIPpJ/s XhAXFnDSW4XFTL0/DwUhhtNgZuY72YmIV0ksp+mRtwG//Y8R4q1J/7BaF1dOFagQsjMm NamSCJFgtmUyDLtItvYpzax6Eu5tbDpfyEDdk= In-Reply-To: <1323614738-7405-3-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Glauber Costa Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jbottomley-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, bsingharora-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org, tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org > -static int notify_on_release(const struct cgroup *cgrp) > +static inline int notify_on_release(const struct cgroup *cgrp) > { > return test_bit(CGRP_NOTIFY_ON_RELEASE,&cgrp->flags); > } > > -static int clone_children(const struct cgroup *cgrp) > +static inline int clone_children(const struct cgroup *cgrp) > { > return test_bit(CGRP_CLONE_CHILDREN,&cgrp->flags); > } Can you please tell us which compiler failed automatic inlining? I suspect gcc is enough sane and we don't need this patch. -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752238Ab1LKS4F (ORCPT ); Sun, 11 Dec 2011 13:56:05 -0500 Received: from mail-qw0-f46.google.com ([209.85.216.46]:41604 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752175Ab1LKS4D (ORCPT ); Sun, 11 Dec 2011 13:56:03 -0500 Message-ID: <4EE4FCBB.9050600@gmail.com> Date: Sun, 11 Dec 2011 13:55:55 -0500 From: KOSAKI Motohiro User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:8.0) Gecko/20111105 Thunderbird/8.0 MIME-Version: 1.0 To: Glauber Costa CC: linux-kernel@vger.kernel.org, jbottomley@parallels.com, cgroups@vger.kernel.org, bsingharora@gmail.com, devel@openvz.org, kamezawa.hiroyu@jp.fujitsu.com, tj@kernel.org Subject: Re: [PATCH 1/3] nitpick: make simple functions inline References: <1323614738-7405-1-git-send-email-glommer@parallels.com> <1323614738-7405-3-git-send-email-glommer@parallels.com> In-Reply-To: <1323614738-7405-3-git-send-email-glommer@parallels.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -static int notify_on_release(const struct cgroup *cgrp) > +static inline int notify_on_release(const struct cgroup *cgrp) > { > return test_bit(CGRP_NOTIFY_ON_RELEASE,&cgrp->flags); > } > > -static int clone_children(const struct cgroup *cgrp) > +static inline int clone_children(const struct cgroup *cgrp) > { > return test_bit(CGRP_CLONE_CHILDREN,&cgrp->flags); > } Can you please tell us which compiler failed automatic inlining? I suspect gcc is enough sane and we don't need this patch.