From: Phillip Susi <psusi@cfl.rr.com>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: change resize ioctl to take device path instead of id
Date: Sun, 11 Dec 2011 22:49:03 -0500 [thread overview]
Message-ID: <4EE579AF.7050101@cfl.rr.com> (raw)
In-Reply-To: <4EE57580.8080907@cn.fujitsu.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 12/11/2011 10:31 PM, Li Zefan wrote:
> Phillip Susi wrote:
>> The resize ioctl took an optional argument that was a string
>> representation of the devid which you wish to resize. For
>> the sake of consistency with the other ioctls that take a
>> device argument, I converted this to take a device path instead
>> of a devid number, and look up the number from the path.
>>
>
> but.. isn't this an ABI change?
Technically no, since the ABI is just a string that may (undocumented) have a colon in it followed by digits.
> so instead of changing it, I think it's ok to extend it.
I considered that at first, but the existing code appears to not handle errors ( what happens when the string can't be converted to an integer? ) and the interface has not been documented until now, so I figured may as well just get rid of it.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk7leawACgkQJ4UciIs+XuIJ3ACeKuQidLKrb/nVqaS13Z1yzzoh
MDAAoIIPhBEnAbmTWdc6M4NBQUdX1+Pv
=7JV1
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2011-12-12 3:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 3:12 [PATCH] btrfs: change resize ioctl to take device path instead of id Phillip Susi
2011-12-12 3:31 ` Li Zefan
2011-12-12 3:49 ` Phillip Susi [this message]
2012-01-09 15:15 ` Phillip Susi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE579AF.7050101@cfl.rr.com \
--to=psusi@cfl.rr.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.