From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:34297)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Ra1Al-0001LD-Ob
	for qemu-devel@nongnu.org; Mon, 12 Dec 2011 03:23:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Ra1Ak-0003Iy-Lt
	for qemu-devel@nongnu.org; Mon, 12 Dec 2011 03:23:43 -0500
Received: from mx1.redhat.com ([209.132.183.28]:7325)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Ra1Ak-0003Ig-Ef
	for qemu-devel@nongnu.org; Mon, 12 Dec 2011 03:23:42 -0500
Message-ID: <4EE5BA00.7040507@redhat.com>
Date: Mon, 12 Dec 2011 09:23:28 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1323326175-25184-1-git-send-email-mars@linux.vnet.ibm.com>
In-Reply-To: <1323326175-25184-1-git-send-email-mars@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Fix parse of usb device description with
	multiple configurations
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Cao,Bing Bu" <mars@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org

  Hi,

> +        } else if (descriptors[i + 5] != s->configuration) {
> +            fprintf(stderr, "not requested configuration %d\n",
> +                    s->configuration);
> +            i += (descriptors[i + 3] << 8) + descriptors[i + 2];
> +            continue;
> +        }

That message doesn't indicate an error and should be a DPRINTF instead
of a fprintf.  Otherwise the patch looks fine.

cheers,
  Gerd