From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54441) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ra2OS-0004wR-Sw for qemu-devel@nongnu.org; Mon, 12 Dec 2011 04:41:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ra2OM-0001nR-Vw for qemu-devel@nongnu.org; Mon, 12 Dec 2011 04:41:56 -0500 Received: from cantor2.suse.de ([195.135.220.15]:35390 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ra2OM-0001nN-RG for qemu-devel@nongnu.org; Mon, 12 Dec 2011 04:41:50 -0500 Message-ID: <4EE5CC1A.90506@suse.de> Date: Mon, 12 Dec 2011 10:40:42 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1323677680.3070.43.camel@concordia> <1323678104-30133-1-git-send-email-michael@ellerman.id.au> <1323678104-30133-2-git-send-email-michael@ellerman.id.au> In-Reply-To: <1323678104-30133-2-git-send-email-michael@ellerman.id.au> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/3] vl.c: Fold constant string into printf rather than using %s List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Ellerman Cc: qemu-devel@nongnu.org Am 12.12.2011 09:21, schrieb Michael Ellerman: > In help() we do what boils down to: >=20 > printf("%s", "qemu"); >=20 > This seems to be an artifact of be995c27640a82c7056b6f53d02ec823570114e= 5 > ("removed unused code"), which removed some ifdef'ery that used to prin= t > a different name depending on CONFIG_SOFTMMU. >=20 > But now that is gone and we always use "qemu" we may as well just put > that in the format string. I would rather propose to save argv[0] and use that. By now "qemu" is not even correct for i386. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg