All of lore.kernel.org
 help / color / mirror / Atom feed
From: roel <roel.kluin@gmail.com>
To: acme@redhat.com, a.p.zijlstra@chello.nl, mingo@elte.hu,
	paulus@samba.org, akpm@linux-foundation.org
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] perf tools: bad lookup in perf_evlist__equal()?
Date: Mon, 12 Dec 2011 20:48:51 +0100	[thread overview]
Message-ID: <4EE65AA3.7070609@gmail.com> (raw)

Fix lookup in perf_evlist__equal()

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
 tools/perf/builtin-record.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Unless this was a feature, but then a comment might be nice
This was introduced in a91e5431d54f5

diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index 6ab58cc..4ccb7d0 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -252,7 +252,7 @@ static bool perf_evlist__equal(struct perf_evlist *evlist,
 	pair = list_entry(other->entries.next, struct perf_evsel, node);
 
 	list_for_each_entry(pos, &evlist->entries, node) {
-		if (memcmp(&pos->attr, &pair->attr, sizeof(pos->attr) != 0))
+		if (memcmp(&pos->attr, &pair->attr, sizeof(pos->attr)) != 0)
 			return false;
 		pair = list_entry(pair->node.next, struct perf_evsel, node);
 	}

             reply	other threads:[~2011-12-12 19:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-12 19:48 roel [this message]
2011-12-13 14:26 ` [PATCH] perf tools: bad lookup in perf_evlist__equal()? Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EE65AA3.7070609@gmail.com \
    --to=roel.kluin@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.