All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ryan Mallon <rmallon@gmail.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'Andrew Morton'" <akpm@linux-foundation.org>,
	"'LKML'" <linux-kernel@vger.kernel.org>,
	"'Richard Purdie'" <rpurdie@rpsys.net>,
	"'H Hartley Sweeten'" <hsweeten@visionengravers.com>
Subject: Re: [PATCH] backlight: ep93xx_bl: remove duplicated header include
Date: Tue, 13 Dec 2011 09:11:27 +1100	[thread overview]
Message-ID: <4EE67C0F.10900@gmail.com> (raw)
In-Reply-To: <001201ccb8a2$ca235e30$5e6a1a90$%han@samsung.com>

On 12/12/11 18:51, Jingoo Han wrote:

> This patch removes duplicated module header for EP93xx backlight
> driver.
> drivers/video/backlight/ep93xx_bl.c: module.h is included more
> than once.
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
>  drivers/video/backlight/ep93xx_bl.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/backlight/ep93xx_bl.c b/drivers/video/backlight/ep93xx_bl.c
> index c74a6f4..4893dff 100644
> --- a/drivers/video/backlight/ep93xx_bl.c
> +++ b/drivers/video/backlight/ep93xx_bl.c
> @@ -10,10 +10,8 @@
>   * This driver controls the pulse width modulated brightness control output,
>   * BRIGHT, on the Cirrus EP9307, EP9312, and EP9315 processors.
>   */
> -


Please don't remove the blank line between the header comment and the
first include.

~Ryan

>  #include <linux/module.h>
>  #include <linux/platform_device.h>
> -#include <linux/module.h>
>  #include <linux/io.h>
>  #include <linux/fb.h>
>  #include <linux/backlight.h>



      parent reply	other threads:[~2011-12-12 22:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-12  7:51 [PATCH] backlight: ep93xx_bl: remove duplicated header include Jingoo Han
2011-12-12 17:24 ` H Hartley Sweeten
2011-12-12 22:11 ` Ryan Mallon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EE67C0F.10900@gmail.com \
    --to=rmallon@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=hsweeten@visionengravers.com \
    --cc=jg1.han@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.