From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:38663) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RaFHx-0002ih-18 for qemu-devel@nongnu.org; Mon, 12 Dec 2011 18:28:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RaFHv-0006S7-Vw for qemu-devel@nongnu.org; Mon, 12 Dec 2011 18:28:05 -0500 Received: from mail-qy0-f173.google.com ([209.85.216.173]:51814) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RaFHv-0006S1-9v for qemu-devel@nongnu.org; Mon, 12 Dec 2011 18:28:03 -0500 Received: by qcsd15 with SMTP id d15so4829113qcs.4 for ; Mon, 12 Dec 2011 15:28:02 -0800 (PST) Message-ID: <4EE68DFF.6050908@codemonkey.ws> Date: Mon, 12 Dec 2011 17:27:59 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1323717136-21661-1-git-send-email-stefanb@linux.vnet.ibm.com> <1323717136-21661-7-git-send-email-stefanb@linux.vnet.ibm.com> In-Reply-To: <1323717136-21661-7-git-send-email-stefanb@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V13 6/7] Introduce --enable-tpm-passthrough configure option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Berger Cc: mst@redhat.com, qemu-devel@nongnu.org, andreas.niederl@iaik.tugraz.at On 12/12/2011 01:12 PM, Stefan Berger wrote: > Introduce --enable-tpm-passthrough configure option. > > Signed-off-by: Stefan Berger > --- > configure | 16 +++++++++++++++- > 1 files changed, 15 insertions(+), 1 deletions(-) > > diff --git a/configure b/configure > index 25995bc..ffb599e 100755 > --- a/configure > +++ b/configure > @@ -186,6 +186,7 @@ zlib="yes" > guest_agent="yes" > libiscsi="" > tpm="no" > +tpm_passthrough="no" Same as before, please probe for existence. Regards, Anthony Liguori > > # parse CC options first > for opt do > @@ -787,11 +788,20 @@ for opt do > ;; > --enable-tpm) tpm="yes" > ;; > + --enable-tpm-passthrough) tpm_passthrough="yes" > + ;; > *) echo "ERROR: unknown option $opt"; show_help="yes" > ;; > esac > done > > +if test "$tpm" = "no" ; then > + if test "$tpm_passthrough" = "yes"; then > + echo "ERROR: --enable-tpm-passthrough requires --enable-tpm" > + exit 1 > + fi > +fi > + > # > # If cpu ~= sparc and sparc_cpu hasn't been defined, plug in the right > # QEMU_CFLAGS/LDFLAGS (assume sparc_v8plus for 32-bit and sparc_v9 for 64-bit) > @@ -1074,6 +1084,7 @@ echo " --enable-usb-redir enable usb network redirection support" > echo " --disable-guest-agent disable building of the QEMU Guest Agent" > echo " --enable-guest-agent enable building of the QEMU Guest Agent" > echo " --enable-tpm enable TPM support" > +echo " --enable-tpm-passthrough enable TPM passthrough driver" > echo "" > echo "NOTE: The object files are built at the place where configure is launched" > exit 1 > @@ -2850,6 +2861,7 @@ echo "OpenGL support $opengl" > echo "libiscsi support $libiscsi" > echo "build guest agent $guest_agent" > echo "TPM support $tpm" > +echo "TPM passthrough $tpm_passthrough" > > if test "$sdl_too_old" = "yes"; then > echo "-> Your SDL version is too old - please upgrade to have SDL support" > @@ -3722,7 +3734,9 @@ fi > if test "$tpm" = "yes"; then > if test "$target_softmmu" = "yes" ; then > if test "$linux" = "yes" ; then > - echo "CONFIG_TPM_PASSTHROUGH=y">> $config_target_mak > + if test "$tpm_passthrough" = "yes" ; then > + echo "CONFIG_TPM_PASSTHROUGH=y">> $config_target_mak > + fi > fi > echo "CONFIG_TPM=y">> $config_host_mak > fi