From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonyoung Shim Subject: Re: [PATCH 5/5] drm/exynos: Add plane support with fimd Date: Tue, 13 Dec 2011 09:13:41 +0900 Message-ID: <4EE698B5.5050406@samsung.com> References: <1323418995-6492-1-git-send-email-inki.dae@samsung.com> <1323428379-12024-1-git-send-email-inki.dae@samsung.com> <1323428379-12024-6-git-send-email-inki.dae@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) by gabe.freedesktop.org (Postfix) with ESMTP id A3E6A9E887 for ; Mon, 12 Dec 2011 16:13:40 -0800 (PST) Received: from epcpsbgm1.samsung.com (mailout2.samsung.com [203.254.224.25]) by mailout2.samsung.com (Oracle Communications Messaging Exchange Server 7u4-19.01 64bit (built Sep 7 2010)) with ESMTP id <0LW400GZN8MAD8B0@mailout2.samsung.com> for dri-devel@lists.freedesktop.org; Tue, 13 Dec 2011 09:13:38 +0900 (KST) Received: from [165.213.219.123] by mmp2.samsung.com (Oracle Communications Messaging Exchange Server 7u4-19.01 64bit (built Sep 7 2010)) with ESMTPA id <0LW40042A8MPKZA0@mmp2.samsung.com> for dri-devel@lists.freedesktop.org; Tue, 13 Dec 2011 09:13:38 +0900 (KST) In-reply-to: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Rob Clark Cc: Inki Dae , kyungmin.park@samsung.com, sw0312.kim@samsung.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On 12/13/2011 07:48 AM, Rob Clark wrote: > On Fri, Dec 9, 2011 at 4:59 AM, Inki Dae wrote: >> +static int >> +exynos_update_plane(struct drm_plane *plane, struct drm_crtc *crtc, >> + struct drm_framebuffer *fb, int crtc_x, int crtc_y, >> + unsigned int crtc_w, unsigned int crtc_h, >> + uint32_t src_x, uint32_t src_y, >> + uint32_t src_w, uint32_t src_h) >> +{ >> + struct exynos_plane *exynos_plane = >> + container_of(plane, struct exynos_plane, base); >> + struct exynos_drm_overlay *overlay =&exynos_plane->overlay; >> + struct exynos_drm_crtc_pos pos; >> + int ret; >> + >> + DRM_DEBUG_KMS("[%d] %s\n", __LINE__, __func__); >> + >> + memset(&pos, 0, sizeof(struct exynos_drm_crtc_pos)); >> + pos.crtc_x = crtc_x; >> + pos.crtc_y = crtc_y; >> + pos.crtc_w = crtc_w; >> + pos.crtc_h = crtc_h; >> + >> + pos.fb_x = src_x; >> + pos.fb_y = src_y; > also, I think src_x/src_y should be interpreted at 16.16/Q16 fixed > point. But elsewhere were I see fb_x/y used it, it doesn't appear to > be interpreted this way. Right, this will be fixed. Thanks. > Also, I *think* that comment was meant to apply to src_h/src_w > (Jesse?), but you seem to ignore these parameters.. > > BR, > -R > > >> + >> + /* TODO: scale feature */ >> + ret = exynos_drm_overlay_update(overlay, fb,&crtc->mode,&pos); >> + if (ret< 0) >> + return ret; >> + >> + exynos_drm_fn_encoder(crtc, overlay, >> + exynos_drm_encoder_crtc_mode_set); >> + exynos_drm_fn_encoder(crtc,&overlay->zpos, >> + exynos_drm_encoder_crtc_plane_commit); >> + >> + exynos_plane->enabled = true; >> + >> + return 0; >> +} >> + > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel >