From: Michael Haggerty <mhagger@alum.mit.edu>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Kevin Sawicki <kevin@github.com>
Subject: Re: [PATCH 4/4] connect.c: drop path_match function
Date: Tue, 13 Dec 2011 04:23:30 +0100 [thread overview]
Message-ID: <4EE6C532.9060306@alum.mit.edu> (raw)
In-Reply-To: <20111213004959.GD3699@sigill.intra.peff.net>
On 12/13/2011 01:49 AM, Jeff King wrote:
> I just did the exact-string match inline in the previous patch. I could
> also have modified path_match to do it. But really, I can't think of a
> worse name for a global function in a system which is all about
> managing content in paths. Unless, you know, it actually matched paths.
> Which it doesn't.
The tacit assumption that a reference is always a file is all over the
code and is often confusing. My
[PATCH v2 02/51] refs: rename "refname" variables
is a step towards making the distinction more explicit, at least in the
refs code.
Michael
--
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
prev parent reply other threads:[~2011-12-13 3:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 0:39 [PATCH 0/4] exact ref-matching for fetch-pack Jeff King
2011-12-13 0:41 ` [PATCH 1/4] drop "match" parameter from get_remote_heads Jeff King
2011-12-13 0:44 ` [PATCH 2/4] t5500: give fully-qualified refs to fetch-pack Jeff King
2011-12-13 0:48 ` [PATCH 3/4] fetch-pack: match refs exactly Jeff King
2011-12-13 0:54 ` Jeff King
2011-12-15 21:46 ` Junio C Hamano
2011-12-13 0:49 ` [PATCH 4/4] connect.c: drop path_match function Jeff King
2011-12-13 3:23 ` Michael Haggerty [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE6C532.9060306@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=git@vger.kernel.org \
--cc=kevin@github.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.