From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [PATCH] libxc: switch to XC_PAGE_* Date: Tue, 13 Dec 2011 15:19:05 +0100 Message-ID: <4EE75ED9.4030407@amd.com> References: <4EDDE199.2090801@amd.com> <20198.5427.127204.527798@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20198.5427.127204.527798@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson Cc: "xen-devel@lists.xensource.com" , Ian Campbell List-Id: xen-devel@lists.xenproject.org On 12/12/11 15:52, Ian Jackson wrote: > Christoph Egger writes ("[Xen-devel] [PATCH] libxc: switch to XC_PAGE_*"): >> Switch to a consistent set of XC_PAGE_* constants. > > This looks reasonable to me but: can you confirm what tests you've > done to check that this doesn't have any actual change to the code ? Is it enough to say a guest boots and runs as before? > Eg it would be good to run it through the preprocessor and see if the > output is identical to before. > > Ian. > -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85689 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632