From: Ryan Mallon <rmallon@gmail.com>
To: Ravishankar karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Cc: gregkh@suse.de, wfp5p@virginia.edu, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/29] Staging: comedi: fix printk issue in dt3000.c
Date: Wed, 14 Dec 2011 12:35:38 +1100 [thread overview]
Message-ID: <4EE7FD6A.1010700@gmail.com> (raw)
In-Reply-To: <1323667181-17252-1-git-send-email-ravishankar.km@greenturtles.in>
On 12/12/11 16:19, Ravishankar karkala Mallikarjunayya wrote:
> This is a patch to the dt3000.c file that fixes up a
> printk warning found by the checkpatch.pl tool.
>
> Converted printks to dev_<levels>.
>
> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
There are still numerous issues with these patches, some which have been
pointed out to you several times now and still exist:
- You are using printk/pr_info, etc where dev_info, etc should be used
- You are converting some KERN_CONT to multiline dev_info, and in doing
so are now printing useless strings.
- Some of the printk's you are 'fixing' should just get removed. Don't
blindly replace things, it just creates churn.
- You are converting some printks to dev_dbg and leaving dev->minor in
the string which is no longer needed.
- There are some subtle format changes introduced by the printk
changes. Not a big deal, but it should be noted in the changelog. It
might affect some userspace tools for the comedi drivers?
- You have multiple patches which do the same thing. Why are there two
patches for converting printk -> dev_dbg in das1800.c for example? Why
not do all of the conversion changes for one file in a single patch?
- Some of your patches don't do what they say they do.
- You have compile errors still.
Some these patches probably are worth applying, but they are just lost
in the noise.
~Ryan
prev parent reply other threads:[~2011-12-14 1:35 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 5:19 [PATCH 01/29] Staging: comedi: fix printk issue in dt3000.c Ravishankar karkala Mallikarjunayya
2011-12-12 5:19 ` [PATCH 02/29] " Ravishankar karkala Mallikarjunayya
2011-12-12 5:19 ` [PATCH 03/29] " Ravishankar karkala Mallikarjunayya
2011-12-12 5:19 ` [PATCH 04/29] " Ravishankar karkala Mallikarjunayya
2011-12-12 5:19 ` [PATCH 05/29] " Ravishankar karkala Mallikarjunayya
2011-12-12 5:19 ` [PATCH 06/29] Staging: comedi: fix printk issue in pcmuio.c Ravishankar karkala Mallikarjunayya
2011-12-12 5:19 ` [PATCH 07/29] " Ravishankar karkala Mallikarjunayya
2011-12-12 5:19 ` [PATCH 08/29] " Ravishankar karkala Mallikarjunayya
2011-12-12 5:19 ` [PATCH 09/29] Staging: comedi: fix printk issue in daqboard2000.c Ravishankar karkala Mallikarjunayya
2011-12-12 5:19 ` [PATCH 10/29] Staging: comedi: fix line over 80 character " Ravishankar karkala Mallikarjunayya
2011-12-14 0:26 ` Greg KH
2011-12-12 5:19 ` [PATCH 11/29] Staging: comedi: fix printk " Ravishankar karkala Mallikarjunayya
2011-12-12 5:19 ` [PATCH 12/29] Staging: comedi: fix printk issue in jr3_pci.c Ravishankar karkala Mallikarjunayya
2011-12-12 5:19 ` [PATCH 13/29] " Ravishankar karkala Mallikarjunayya
2011-12-12 5:19 ` [PATCH 14/29] Staging: comedi: fix brace coding style issue in ni_at_a2150.c Ravishankar karkala Mallikarjunayya
2011-12-12 5:19 ` [PATCH 15/29] " Ravishankar karkala Mallikarjunayya
2011-12-14 0:29 ` Greg KH
2011-12-12 5:19 ` [PATCH 16/29] " Ravishankar karkala Mallikarjunayya
2011-12-14 0:30 ` Greg KH
2011-12-12 5:19 ` [PATCH 17/29] Staging: comedi: fix printk issue in das1800.c Ravishankar karkala Mallikarjunayya
2011-12-12 5:19 ` [PATCH 18/29] Staging: comedi: fix printk issue in daqboard2000.c Ravishankar karkala Mallikarjunayya
2011-12-12 5:19 ` [PATCH 19/29] Staging: comedi: fix printk issue in das1800.c Ravishankar karkala Mallikarjunayya
2011-12-12 5:19 ` [PATCH 20/29] " Ravishankar karkala Mallikarjunayya
2011-12-12 5:19 ` [PATCH 21/29] Staging: comedi: fix printk issue in cb_pcidas.c Ravishankar karkala Mallikarjunayya
2011-12-12 5:19 ` [PATCH 22/29] " Ravishankar karkala Mallikarjunayya
2011-12-12 5:19 ` [PATCH 23/29] Staging: comedi: fix printk issue in cb_pcidas64.c Ravishankar karkala Mallikarjunayya
2011-12-12 5:19 ` [PATCH 24/29] " Ravishankar karkala Mallikarjunayya
2011-12-12 5:19 ` [PATCH 25/29] Staging: comedi: fix brace coding style issue in cb_pcidda.c Ravishankar karkala Mallikarjunayya
2011-12-14 0:38 ` Greg KH
2011-12-12 5:19 ` [PATCH 26/29] Staging: comedi: fix printk issue in das1800.c Ravishankar karkala Mallikarjunayya
2011-12-12 5:19 ` [PATCH 27/29] " Ravishankar karkala Mallikarjunayya
2011-12-12 5:19 ` [PATCH 28/29] Staging: comedi: fix printk issue in contec_pci_dio.c Ravishankar karkala Mallikarjunayya
2011-12-12 5:19 ` [PATCH 29/29] " Ravishankar karkala Mallikarjunayya
2011-12-14 0:48 ` Greg KH
2011-12-14 1:35 ` Ryan Mallon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE7FD6A.1010700@gmail.com \
--to=rmallon@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ravishankar.km@greenturtles.in \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.