Re: [PATCH RESEND 1/2] MFD: MAX8997: add platform data and devices for LED control

[Donggeun Kim <dg77.kim@samsung.com>]

Hi Samuel,

On 2011년 12월 14일 05:59, Samuel Ortiz wrote:
> Hi Donggeun,
> 
> On Tue, Dec 13, 2011 at 05:13:52PM +0900, Donggeun Kim wrote:
>> diff --git a/drivers/mfd/max8997.c b/drivers/mfd/max8997.c
>> index 5be53ae..cb83a7a 100644
>> --- a/drivers/mfd/max8997.c
>> +++ b/drivers/mfd/max8997.c
>> @@ -43,7 +43,8 @@ static struct mfd_cell max8997_devs[] = {
>>  	{ .name = "max8997-battery", },
>>  	{ .name = "max8997-haptic", },
>>  	{ .name = "max8997-muic", },
>> -	{ .name = "max8997-flash", },
> That doesn't seem to be related to this patch.
> 
> 
Actually, the name of 'max8997-flash' is intended to be used for LED
driver. I think the device name has 'led' suffix rather than 'flash', as
the driver of MAX8997 is included in led class.
>> +	{ .name = "max8997-led", .id = 1 },
>> +	{ .name = "max8997-led", .id = 2 },
>>  };
>> @@ -172,7 +194,8 @@ struct max8997_platform_data {
>>  
>>  	/* HAPTIC: Not implemented */
>>  	/* RTC: Not implemented */
>> -	/* Flash: Not implemented */
>> +	/* ---- Flash ---- */
>> +	struct max8997_led_platform_data *led_pdata;
> This is a bit confusing: Flash and LED ?
> 
LED would be better. I will fix it.
> Cheers,
> Samuel.
> 

Thanks.
-Donggeun