All of lore.kernel.org
 help / color / mirror / Atom feed
From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 07/11] davinci: dm644x: Replace register base value with a defined macro
Date: Wed, 14 Dec 2011 14:36:41 +0400	[thread overview]
Message-ID: <4EE87C39.8010601@mvista.com> (raw)
In-Reply-To: <1323775415-24504-8-git-send-email-manjunath.hadli@ti.com>

Hello.

On 13-12-2011 15:23, Manjunath Hadli wrote:

> Replace hard coded value of vpss register base to a define macro
> DM644X_VPSS_REG_BASE for proper readability

> Signed-off-by: Manjunath Hadli<manjunath.hadli@ti.com>
> Acked-by: Sekhar Nori<nsekhar@ti.com>
> ---
>   arch/arm/mach-davinci/dm644x.c |    8 +++++---
>   1 files changed, 5 insertions(+), 3 deletions(-)

> diff --git a/arch/arm/mach-davinci/dm644x.c b/arch/arm/mach-davinci/dm644x.c
> index 6b1d473..3802b59 100644
> --- a/arch/arm/mach-davinci/dm644x.c
> +++ b/arch/arm/mach-davinci/dm644x.c
> @@ -594,13 +594,15 @@ static struct platform_device dm644x_asp_device = {
>   	.resource	= dm644x_asp_resources,
>   };
>
> +#define DM644X_VPSS_REG_BASE	0x01c73400
> +

    Why not simply DM644X_VPSS_BASE, like all the other #define's?

WBR, Sergei

  reply	other threads:[~2011-12-14 10:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-13 11:23 [PATCH v5 00/11]ARM: davinci:add support for dm644x vpbe display driver Manjunath Hadli
2011-12-13 11:23 ` [PATCH v5 01/11] davinci: vpif: remove obsolete header file inclusion Manjunath Hadli
2011-12-13 11:23   ` Manjunath Hadli
2011-12-13 11:23 ` [PATCH v5 02/11] ARM: davinci: dm644x: remove the macros from the header to move to c file Manjunath Hadli
2011-12-13 11:23 ` [PATCH v5 03/11] ARM: davinci: dm365: " Manjunath Hadli
2011-12-13 11:23 ` [PATCH v5 04/11] ARM: davinci: dm646x: " Manjunath Hadli
2011-12-13 11:23 ` [PATCH v5 05/11] ARM: davinci: create new common platform header for davinci Manjunath Hadli
2011-12-13 11:23 ` [PATCH v5 06/11] davinci: eliminate use of IO_ADDRESS() on sysmod Manjunath Hadli
2011-12-13 11:23 ` [PATCH v5 07/11] davinci: dm644x: Replace register base value with a defined macro Manjunath Hadli
2011-12-14 10:36   ` Sergei Shtylyov [this message]
2011-12-15 11:11     ` Hadli, Manjunath
2011-12-13 11:23 ` [PATCH v5 08/11] davinci: dm644x: change vpfe capture structure variables for consistency Manjunath Hadli
2011-12-13 11:23 ` [PATCH v5 09/11] davinci: dm644x: move vpfe init from soc to board specific files Manjunath Hadli
2011-12-13 11:23 ` [PATCH v5 10/11] davinci: dm644x: add support for v4l2 video display Manjunath Hadli
2011-12-14 10:48   ` Sergei Shtylyov
2011-12-15 11:13     ` Hadli, Manjunath
2011-12-13 11:23 ` [PATCH v5 11/11] davinci: dm644x EVM: add support for VPBE display Manjunath Hadli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EE87C39.8010601@mvista.com \
    --to=sshtylyov@mvista.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.