All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [pull request v2] Pull request for branch for-2011.11/pkg-device
Date: Wed, 14 Dec 2011 11:39:42 +0100	[thread overview]
Message-ID: <4EE87CEE.5050304@free-electrons.com> (raw)
In-Reply-To: <cover.1315577080.git.maxime.ripard@free-electrons.com>

Hi,

Any review on that ?

The cramfs patch should obviously be dropped, as it has already been
applied. From what I read in the BDD report, the renaming of the
device_table should also be dropped. But it also says that a more
precise comment on what the attendees expected would be given.

Maxime

On 09/09/2011 16:05, Maxime Ripard wrote:
> Hello,
> 
> Here is a minor set of improvement on how the devices are
> declared in buildroot. For now, All the devices to be created
> were in two files generic to every compilation. This was fine
> for most usage, but was a bit problematic when packages needed
> to create files or use specific permissions.
> 
> This set of patches are addressing this issue by creating a
> new $(PKG)_FILES variable, containing the package specific
> devices, using the makedevs syntax.
> 
> Changes since v1:
>   * Rename the device tables and all mentions of devices to a more exact term
>   * Cramfs was still passing a hardcoded device table. Remove it.
> 
> The following changes since commit facd602dcad54df769ac759886f48f248b61e692:
> 
>   Update for 2011.08 (2011-08-31 13:44:55 +0200)
> 
> are available in the git repository at:
>   http://free-electrons.com/~maxime/git/buildroot.git for-2011.11/pkg-device
> 
> Maxime Ripard (4):
>       Cleanup cramfs package declaration.
>       Rename the device table in the code base
>       Add support for package-declared devices
>       Convert busybox to the device declaration method
> 
>  Makefile                                           |    4 +
>  fs/common.mk                                       |   15 +-
>  fs/cramfs/cramfs.mk                                |    6 +-
>  package/Makefile.package.in                        |    1 +
>  package/busybox/busybox.mk                         |    5 +
>  package/cramfs/cramfs-01-devtable.patch            | 1269 --------------------
>  ...amfs-02-endian.patch => cramfs-01-endian.patch} |   68 +-
>  package/cramfs/cramfs-02-cygwin_IO.patch           |   15 +
>  package/cramfs/cramfs-03-cygwin_IO.patch           |   13 -
>  .../{device_table.txt => file_install_table.txt}   |    0
>  target/generic/Config.in                           |    6 +-
>  .../{device_table.txt => file_install_table.txt}   |    2 -
>  ...evice_table_dev.txt => static_device_table.txt} |    0
>  target/xtensa/defconfig                            |    2 +-
>  14 files changed, 74 insertions(+), 1332 deletions(-)
>  delete mode 100644 package/cramfs/cramfs-01-devtable.patch
>  rename package/cramfs/{cramfs-02-endian.patch => cramfs-01-endian.patch} (86%)
>  create mode 100644 package/cramfs/cramfs-02-cygwin_IO.patch
>  delete mode 100644 package/cramfs/cramfs-03-cygwin_IO.patch
>  rename target/device/xtensa/{device_table.txt => file_install_table.txt} (100%)
>  rename target/generic/{device_table.txt => file_install_table.txt} (90%)
>  rename target/generic/{device_table_dev.txt => static_device_table.txt} (100%)
> 
> Thanks,


-- 
Maxime Ripard, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  parent reply	other threads:[~2011-12-14 10:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-09 14:05 [Buildroot] [pull request v2] Pull request for branch for-2011.11/pkg-device Maxime Ripard
2011-09-09 14:05 ` [Buildroot] [PATCH 1/4] Cleanup cramfs package declaration Maxime Ripard
2011-10-27 13:43   ` Peter Korsgaard
2011-09-09 14:05 ` [Buildroot] [PATCH 2/4] Rename the device table in the code base Maxime Ripard
2011-09-09 14:05 ` [Buildroot] [PATCH 3/4] Add support for package-declared devices Maxime Ripard
2011-09-09 14:05 ` [Buildroot] [PATCH 4/4] Convert busybox to the device declaration method Maxime Ripard
2011-09-30 21:52 ` [Buildroot] [pull request v2] Pull request for branch for-2011.11/pkg-device Maxime Ripard
2011-12-14 10:39 ` Maxime Ripard [this message]
2011-12-14 10:43   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EE87CEE.5050304@free-electrons.com \
    --to=maxime.ripard@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.