From: Anthony Liguori <anthony@codemonkey.ws>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/4] memory: make memory API parsable by gtkdoc-scan
Date: Wed, 14 Dec 2011 11:19:56 -0600 [thread overview]
Message-ID: <4EE8DABC.8050902@codemonkey.ws> (raw)
In-Reply-To: <CAFEAcA8_MOLv8gqAoD2t8=Dhscmx3jXrTUfuyg2jKBY-dRCk9Q@mail.gmail.com>
On 12/14/2011 11:11 AM, Peter Maydell wrote:
> On 14 December 2011 16:55, Anthony Liguori<anthony@codemonkey.ws> wrote:
>> I think in this case, we're just going to have to deviate from the standard.
>> The benefit is great, the practice is widespread, and there's no immediate
>> likelihood of changing glib's coding style practices.
>>
>> I still think we should adhere to this policy where ever possible but I
>> think we'll have to make an exception for extracting documentation.
>
> Disagree. A docs tool that requires us to change our coding/naming
> conventions (as opposed to merely how we mark stuff up in comments
> or whatever) is a broken tool. Doubly so if it mandates violation
> of the C standards.
>
> We want to be able to document the structs/whatever we have now,
> not only after we've done some enormous change to every struct we
> have to bring it into line with somebody else's conventions.
If you have a better suggestion, I'm all for it. But since C is not the most
parseable language ever invented, basically every tool comes with constraints
about coding style.
We can spend forever searching for the perfect tool, invent one ourselves, or
just suck it up and use what's already out there.
The C language enforcement police aren't going to come knocking at our doors
tomorrow. This doesn't create a bug or remove a feature.
At some level, we need to be pragmatic.
Regards,
Anthony Liguori
>
> -- PMM
>
next prev parent reply other threads:[~2011-12-14 17:20 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 16:20 [Qemu-devel] [PATCH 0/4] GTK-DOC build integration Anthony Liguori
2011-12-14 16:20 ` [Qemu-devel] [PATCH 1/4] memory: make memory API parsable by gtkdoc-scan Anthony Liguori
2011-12-14 16:34 ` malc
2011-12-14 16:55 ` Anthony Liguori
2011-12-14 17:11 ` Peter Maydell
2011-12-14 17:19 ` Anthony Liguori [this message]
2011-12-14 17:26 ` Peter Maydell
2011-12-14 18:00 ` Anthony Liguori
2011-12-14 17:55 ` Stefan Weil
2011-12-15 9:20 ` Avi Kivity
2011-12-15 13:35 ` Anthony Liguori
2011-12-14 18:54 ` Stefan Weil
2011-12-14 19:03 ` Anthony Liguori
2011-12-14 20:48 ` Stefan Weil
2011-12-14 20:54 ` Anthony Liguori
2011-12-14 21:26 ` Stefan Weil
2011-12-14 21:51 ` Anthony Liguori
2011-12-14 22:23 ` Stefan Weil
2011-12-14 22:37 ` Anthony Liguori
2011-12-14 20:23 ` Eric Blake
2011-12-14 20:43 ` malc
2011-12-14 20:49 ` Anthony Liguori
2011-12-14 16:20 ` [Qemu-devel] [PATCH 2/4] docs: add build infrastructure for gtkdocs Anthony Liguori
2011-12-15 9:37 ` Avi Kivity
2011-12-15 10:06 ` Stefan Weil
2011-12-15 13:30 ` Anthony Liguori
2011-12-15 13:43 ` Avi Kivity
2011-12-15 14:10 ` Anthony Liguori
2011-12-16 5:01 ` Andreas Färber
2011-12-14 16:20 ` [Qemu-devel] [PATCH 3/4] memory: update documentation to be in gtk-doc format Anthony Liguori
2011-12-15 9:26 ` Avi Kivity
2011-12-15 13:33 ` Anthony Liguori
2011-12-15 13:44 ` Avi Kivity
2011-12-14 16:20 ` [Qemu-devel] [PATCH 4/4] memory: move header into include/ and add to QEMU docs Anthony Liguori
2011-12-15 9:24 ` Avi Kivity
2011-12-15 13:34 ` Anthony Liguori
2011-12-15 13:45 ` Avi Kivity
2011-12-15 14:12 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE8DABC.8050902@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.