All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zumeng Chen <zumeng.chen@windriver.com>
To: Bruce Ashfield <bruce.ashfield@windriver.com>
Cc: yocto@yoctoproject.org
Subject: Re: [PATCH 1/1] remove usbgadget from routerstationpro
Date: Thu, 15 Dec 2011 09:01:57 +0800	[thread overview]
Message-ID: <4EE94705.20807@windriver.com> (raw)
In-Reply-To: <4EE8B0C1.5010202@windriver.com>

于 2011年12月14日 22:20, Bruce Ashfield 写道:
> On 11-12-14 04:31 AM, Zumeng Chen wrote:
>> 1. No mass storage needed to be accessed by usbgadget.
>> 2. This is a router station& switch, so it should not
>> be taken as a USB_NET device too.
>
> Zumeng,
>
> The comment from the bug reporter was also that the target
> doesn't have USB slave hardware to support usbgadget. So mentioning
> that in the header is probably a good idea as well.
OK, will add it, generally speaking MTD can be used as the slave,
but obviously it's meaningless here. Soon V2

Regards,
Zumeng
>
> And small comment indicating that as a result of these conditions,
> we remove usbgadget from MACHINE_FEATURES, since it can't be used.
> Would complete the header.
>
> Cheers,
>
> Bruce
>
>>
>> Signed-off-by: Zumeng.chen@windriver.com>
>> ---
>> meta-yocto/conf/machine/routerstationpro.conf | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/meta-yocto/conf/machine/routerstationpro.conf 
>> b/meta-yocto/conf/machine/routerstationpro.conf
>> index 9338ca1..52124d9 100644
>> --- a/meta-yocto/conf/machine/routerstationpro.conf
>> +++ b/meta-yocto/conf/machine/routerstationpro.conf
>> @@ -5,7 +5,7 @@
>> require conf/machine/include/tune-mips32.inc
>>
>> MACHINE_FEATURES = "kernel26 screen keyboard pci usbhost ext2 ext3 \
>> - serial usbgadget"
>> + serial"
>>
>> KERNEL_IMAGETYPE = "vmlinux"
>> KERNEL_ALT_IMAGETYPE = "vmlinux.bin"
>



  reply	other threads:[~2011-12-15  1:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-14  9:31 [PATCH 1/1] remove usbgadget from routerstationpro Zumeng Chen
2011-12-14 14:20 ` Bruce Ashfield
2011-12-15  1:01   ` Zumeng Chen [this message]
2011-12-15  1:02   ` [V2 PATCH " Zumeng Chen
2011-12-15  1:47     ` Bruce Ashfield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EE94705.20807@windriver.com \
    --to=zumeng.chen@windriver.com \
    --cc=bruce.ashfield@windriver.com \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.