From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joonyoung Shim <jy0922.shim@samsung.com>
Subject: Re: [PATCH v2 5/5] drm/exynos: Add plane support with fimd
Date: Thu, 15 Dec 2011 11:23:37 +0900
Message-ID: <4EE95A29.6000601@samsung.com>
References: <1323856815-10213-1-git-send-email-jy0922.shim@samsung.com>
	<20111214092635.67dee650@jbarnes-desktop>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34])
	by gabe.freedesktop.org (Postfix) with ESMTP id 132D59E87A
	for <dri-devel@lists.freedesktop.org>;
	Wed, 14 Dec 2011 18:23:39 -0800 (PST)
Received: from epcpsbgm1.samsung.com (mailout4.samsung.com [203.254.224.34])
	by mailout4.samsung.com
	(Oracle Communications Messaging Exchange Server 7u4-19.01 64bit (built
	Sep 7
	2010)) with ESMTP id <0LW8004443ZDVJH0@mailout4.samsung.com> for
	dri-devel@lists.freedesktop.org; Thu, 15 Dec 2011 11:23:38 +0900 (KST)
Received: from [165.213.219.123] by mmp2.samsung.com
	(Oracle Communications Messaging Exchange Server 7u4-19.01 64bit (built
	Sep 7 2010)) with ESMTPA id <0LW800EK53ZD0XH0@mmp2.samsung.com> for
	dri-devel@lists.freedesktop.org; Thu, 15 Dec 2011 11:23:37 +0900 (KST)
In-reply-to: <20111214092635.67dee650@jbarnes-desktop>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: inki.dae@samsung.com, kyungmin.park@samsung.com, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On 12/15/2011 02:26 AM, Jesse Barnes wrote:
> On Wed, 14 Dec 2011 19:00:15 +0900
> Joonyoung Shim<jy0922.shim@samsung.com>  wrote:
>
>> The exynos fimd supports 5 window overlays. Only one window overlay of
>> fimd is used by the crtc, so we need plane feature to use the rest
>> window overlays.
>>
>> This creates one ioctl exynos specific - DRM_EXYNOS_PLANE_SET_ZPOS, it
>> is the ioctl to decide for user to assign which window overlay.
>>
>> Signed-off-by: Joonyoung Shim<jy0922.shim@samsung.com>
>> Signed-off-by: Inki Dae<inki.dae@samsung.com>
>> Signed-off-by: Kyungmin Park<kyungmin.park@samsung.com>
>> ---
>> v2: consider fixed point about src_x/src_y
> Looks pretty good; the only thing that jumped out was that you don't
> seem to be validating the zpos ioctl parameters for sanity.  Not sure
> if there's much to do, but it may be worth checking for a max zpos or
> something...
>

OK, i added to check to be validating the zpos ioctl parameter.

Thanks.