All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] question regarding generic board.c
Date: Thu, 15 Dec 2011 11:02:09 +0100	[thread overview]
Message-ID: <4EE9C5A1.3010007@gmail.com> (raw)

Hi all,

I encountered a compile warning in avr32 which lead me to the fact that
every board.c utilizes these three lines:

---8<---
#if defined(CONFIG_CMD_NET)
	s = getenv("bootfile");
	if (s)
		copy_filename(BootFile, s, sizeof(BootFile));
#endif
--->8---

I know there is currently some effort to move the common stuff out of
the respective board.c files and this part would be one of these. But I
wonder if this specific part shouldn't move into the network framework.
The BootFile is declared in net/ and is only required if some ethernet
device is attached. The ethernet stuff will be initialized by
eth_initialize(), this could be one place for setting BootFile initial
but maybe there are better places.

Any comments?

best regards

Andreas Bie?mann

             reply	other threads:[~2011-12-15 10:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-15 10:02 Andreas Bießmann [this message]
2011-12-27  5:20 ` [U-Boot] question regarding generic board.c Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EE9C5A1.3010007@gmail.com \
    --to=andreas.devel@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.