From mboxrd@z Thu Jan 1 00:00:00 1970 From: robherring2@gmail.com (Rob Herring) Date: Thu, 15 Dec 2011 08:01:46 -0600 Subject: [PATCH 3/9] irq: convert generic-chip to use irq_domain In-Reply-To: <20111215140827.GB2963@S2100-06.ap.freescale.net> References: <1323876538-20406-1-git-send-email-robherring2@gmail.com> <1323876538-20406-4-git-send-email-robherring2@gmail.com> <20111215052512.GB21815@S2101-09.ap.freescale.net> <20111215055501.GC21815@S2101-09.ap.freescale.net> <4EE9F899.7010402@gmail.com> <20111215140827.GB2963@S2100-06.ap.freescale.net> Message-ID: <4EE9FDCA.5080906@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 12/15/2011 08:08 AM, Shawn Guo wrote: > On Thu, Dec 15, 2011 at 07:39:37AM -0600, Rob Herring wrote: >> On 12/14/2011 11:55 PM, Shawn Guo wrote: >>> On Thu, Dec 15, 2011 at 01:25:20PM +0800, Shawn Guo wrote: >>>> On Wed, Dec 14, 2011 at 09:28:52AM -0600, Rob Herring wrote: >>>>> From: Rob Herring >>>>> >>>>> Add irq domain support to irq generic-chip. This enables users of >>>>> generic-chip to support dynamic irq assignment needed for DT interrupt >>>>> binding. Users must be converted to use irq_data.hwirq for determining >>>>> local interrupt numbers rather than using the Linux irq number. >>>>> >>>>> irq_base is kept for now as there are a few users of it. Once they >>>>> are converted to use the irq domain, it can be removed. >>>>> >>>>> Signed-off-by: Rob Herring >>>>> Cc: Thomas Gleixner >>>>> --- >>>> >>>> Tested-by: Shawn Guo >>>> >>> Sorry, I have to take that tag back after I correct my test setup. >>> It does not work for imx5 TZIC case, because the following change >>> I suggested before is missed. >>> >>> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c >>> index eb763f7..2a2aac1 100644 >>> --- a/kernel/irq/irqdomain.c >>> +++ b/kernel/irq/irqdomain.c >>> @@ -39,7 +39,7 @@ void irq_domain_add(struct irq_domain *domain) >>> return; >>> } >>> d->domain = domain; >>> - d->hwirq = hwirq; >>> + d->hwirq = hwirq - domain->hwirq_base; >> >> This is a problem. It entirely defeats the point of hwirq_base and it >> would break the GIC. We need to fix this in the generic irq chip. >> > Actually I do not quite understand why we need to make the following > change all over generic-chip.c. > > - u32 mask = 1 << (d->irq - gc->irq_base); > + u32 mask = 1 << d->hwirq; > > Though d->irq is the Linux irq number, "d->irq - gc->irq_base" is > really just what we need here. That's assuming a linear mapping between the irq and hwirq. What if we start allocating irq_descs on demand within a domain? Then there would be no way to convert. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 3/9] irq: convert generic-chip to use irq_domain Date: Thu, 15 Dec 2011 08:01:46 -0600 Message-ID: <4EE9FDCA.5080906@gmail.com> References: <1323876538-20406-1-git-send-email-robherring2@gmail.com> <1323876538-20406-4-git-send-email-robherring2@gmail.com> <20111215052512.GB21815@S2101-09.ap.freescale.net> <20111215055501.GC21815@S2101-09.ap.freescale.net> <4EE9F899.7010402@gmail.com> <20111215140827.GB2963@S2100-06.ap.freescale.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20111215140827.GB2963-+NayF8gZjK2ctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Shawn Guo Cc: Kevin Hilman , Kukjin Kim , Tony Lindgren , Linus Walleij , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Barry Song , Thomas Gleixner , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On 12/15/2011 08:08 AM, Shawn Guo wrote: > On Thu, Dec 15, 2011 at 07:39:37AM -0600, Rob Herring wrote: >> On 12/14/2011 11:55 PM, Shawn Guo wrote: >>> On Thu, Dec 15, 2011 at 01:25:20PM +0800, Shawn Guo wrote: >>>> On Wed, Dec 14, 2011 at 09:28:52AM -0600, Rob Herring wrote: >>>>> From: Rob Herring >>>>> >>>>> Add irq domain support to irq generic-chip. This enables users of >>>>> generic-chip to support dynamic irq assignment needed for DT interrupt >>>>> binding. Users must be converted to use irq_data.hwirq for determining >>>>> local interrupt numbers rather than using the Linux irq number. >>>>> >>>>> irq_base is kept for now as there are a few users of it. Once they >>>>> are converted to use the irq domain, it can be removed. >>>>> >>>>> Signed-off-by: Rob Herring >>>>> Cc: Thomas Gleixner >>>>> --- >>>> >>>> Tested-by: Shawn Guo >>>> >>> Sorry, I have to take that tag back after I correct my test setup. >>> It does not work for imx5 TZIC case, because the following change >>> I suggested before is missed. >>> >>> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c >>> index eb763f7..2a2aac1 100644 >>> --- a/kernel/irq/irqdomain.c >>> +++ b/kernel/irq/irqdomain.c >>> @@ -39,7 +39,7 @@ void irq_domain_add(struct irq_domain *domain) >>> return; >>> } >>> d->domain = domain; >>> - d->hwirq = hwirq; >>> + d->hwirq = hwirq - domain->hwirq_base; >> >> This is a problem. It entirely defeats the point of hwirq_base and it >> would break the GIC. We need to fix this in the generic irq chip. >> > Actually I do not quite understand why we need to make the following > change all over generic-chip.c. > > - u32 mask = 1 << (d->irq - gc->irq_base); > + u32 mask = 1 << d->hwirq; > > Though d->irq is the Linux irq number, "d->irq - gc->irq_base" is > really just what we need here. That's assuming a linear mapping between the irq and hwirq. What if we start allocating irq_descs on demand within a domain? Then there would be no way to convert. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758892Ab1LOOBw (ORCPT ); Thu, 15 Dec 2011 09:01:52 -0500 Received: from mail-yx0-f174.google.com ([209.85.213.174]:51649 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751199Ab1LOOBv (ORCPT ); Thu, 15 Dec 2011 09:01:51 -0500 Message-ID: <4EE9FDCA.5080906@gmail.com> Date: Thu, 15 Dec 2011 08:01:46 -0600 From: Rob Herring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111124 Thunderbird/8.0 MIME-Version: 1.0 To: Shawn Guo CC: Kevin Hilman , Kukjin Kim , Tony Lindgren , Linus Walleij , devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, Rob Herring , Barry Song , Thomas Gleixner , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/9] irq: convert generic-chip to use irq_domain References: <1323876538-20406-1-git-send-email-robherring2@gmail.com> <1323876538-20406-4-git-send-email-robherring2@gmail.com> <20111215052512.GB21815@S2101-09.ap.freescale.net> <20111215055501.GC21815@S2101-09.ap.freescale.net> <4EE9F899.7010402@gmail.com> <20111215140827.GB2963@S2100-06.ap.freescale.net> In-Reply-To: <20111215140827.GB2963@S2100-06.ap.freescale.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/15/2011 08:08 AM, Shawn Guo wrote: > On Thu, Dec 15, 2011 at 07:39:37AM -0600, Rob Herring wrote: >> On 12/14/2011 11:55 PM, Shawn Guo wrote: >>> On Thu, Dec 15, 2011 at 01:25:20PM +0800, Shawn Guo wrote: >>>> On Wed, Dec 14, 2011 at 09:28:52AM -0600, Rob Herring wrote: >>>>> From: Rob Herring >>>>> >>>>> Add irq domain support to irq generic-chip. This enables users of >>>>> generic-chip to support dynamic irq assignment needed for DT interrupt >>>>> binding. Users must be converted to use irq_data.hwirq for determining >>>>> local interrupt numbers rather than using the Linux irq number. >>>>> >>>>> irq_base is kept for now as there are a few users of it. Once they >>>>> are converted to use the irq domain, it can be removed. >>>>> >>>>> Signed-off-by: Rob Herring >>>>> Cc: Thomas Gleixner >>>>> --- >>>> >>>> Tested-by: Shawn Guo >>>> >>> Sorry, I have to take that tag back after I correct my test setup. >>> It does not work for imx5 TZIC case, because the following change >>> I suggested before is missed. >>> >>> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c >>> index eb763f7..2a2aac1 100644 >>> --- a/kernel/irq/irqdomain.c >>> +++ b/kernel/irq/irqdomain.c >>> @@ -39,7 +39,7 @@ void irq_domain_add(struct irq_domain *domain) >>> return; >>> } >>> d->domain = domain; >>> - d->hwirq = hwirq; >>> + d->hwirq = hwirq - domain->hwirq_base; >> >> This is a problem. It entirely defeats the point of hwirq_base and it >> would break the GIC. We need to fix this in the generic irq chip. >> > Actually I do not quite understand why we need to make the following > change all over generic-chip.c. > > - u32 mask = 1 << (d->irq - gc->irq_base); > + u32 mask = 1 << d->hwirq; > > Though d->irq is the Linux irq number, "d->irq - gc->irq_base" is > really just what we need here. That's assuming a linear mapping between the irq and hwirq. What if we start allocating irq_descs on demand within a domain? Then there would be no way to convert. Rob