From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rick Jones <rick.jones2@hp.com>
Subject: Re: twice past the taps, thence out to net?
Date: Thu, 15 Dec 2011 10:32:56 -0800
Message-ID: <4EEA3D58.5010101@hp.com>
References: <4EE8F884.1010304@hp.com> <CAGK4HS-+jj9cvvirDm96oRvRJdwC+2kjE_LnSOXBuQy0pfnQjg@mail.gmail.com> <1323970998.2769.18.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Vijay Subramanian <subramanian.vijay@gmail.com>,
	tcpdump-workers@lists.tcpdump.org, netdev@vger.kernel.org
To: Eric Dumazet <eric.dumazet@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from g5t0009.atlanta.hp.com ([15.192.0.46]:26443 "EHLO
	g5t0009.atlanta.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751366Ab1LOSc6 (ORCPT
	<rfc822;netdev@vger.kernel.org>); Thu, 15 Dec 2011 13:32:58 -0500
In-Reply-To: <1323970998.2769.18.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>


> More exactly, we call dev_queue_xmit_nit() from dev_hard_start_xmit()
> _before_ giving skb to device driver.
>
> If device driver returns NETDEV_TX_BUSY, and a qdisc was setup on the
> device, packet is requeued.
>
> Later, when queue is allowed to send again packets, packet is
> retransmitted (and traced a second time in dev_queue_xmit_nit())

Is this then an unintended consequence bug, or a known feature?

rick

> You can see the 'requeues' counter from "tc -s -d qdisc" output :
>
> qdisc mq 0: dev eth2 root
>   Sent 29421597369 bytes 20301716 pkt (dropped 0, overlimits 0 requeues 371)
>   backlog 0b 0p requeues 371

Sure enough:

$ tc -s -d qdisc
qdisc mq 0: dev eth0 root
  Sent 2212158799862 bytes 1938268098 pkt (dropped 0, overlimits 0 
requeues 4975139)
  backlog 0b 0p requeues 4975139

rick jones