From: Arun Sharma <asharma@fb.com>
To: <avagin@gmail.com>
Cc: <avagin@openvz.org>, Frederic Weisbecker <fweisbec@gmail.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
<linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>, Paul Mackerras <paulus@samba.org>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Subject: Re: [PATCH 3/4] trace: add ability to collect call chain of non-current task.
Date: Thu, 15 Dec 2011 11:08:54 -0800 [thread overview]
Message-ID: <4EEA45C6.2020106@fb.com> (raw)
In-Reply-To: <4EEA101C.7060505@gmail.com>
On 12/15/11 7:19 AM, Andrew Vagin wrote:
>>> * It doesn't distinguish blocking time and sleeping time.
>>
>> Can't we distinguish based on next->state?
> It will be "Running". We can distinguish based on block_start of
> sleep_start
Sounds good.
>>
>>> * This patch does a bit mess between subsystems...
>>
>> Which subsystems?
> sched_switch belongs to scheduler.
> sched_stat belongs to sched_fair.
>
My reading of the code is that 'struct sched_statistics' is independent
of the scheduling class. But only sched_fair.c is actually populating
the stats. Other classes could populate those fields if they choose to.
> It works for me. You can find output of commands bellow.
>
> # ./perf record -e sched:sched_switch -agP
Thanks. I forgot to use the -P option you added on my cmdline.
I still need to investigate why per-process mode (command line without
-a) doesn't work. Will send an updated patch once that's fixed.
-Arun
next prev parent reply other threads:[~2011-12-15 19:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 15:55 [PATCH 0/4] trace: add ability to collect call chains of non-current task Andrew Vagin
2011-09-26 15:55 ` [PATCH 1/4] perf: fix counter of ftrace events Andrew Vagin
2011-10-14 19:11 ` Arun Sharma
2011-09-26 15:55 ` [PATCH 2/4] trace: prepare to collect call chains of non-current task Andrew Vagin
2011-09-27 14:02 ` Peter Zijlstra
2011-10-14 19:12 ` Arun Sharma
2011-09-26 15:55 ` [PATCH 3/4] trace: add ability to collect call chain " Andrew Vagin
2011-09-27 14:05 ` Peter Zijlstra
2011-09-27 20:55 ` Frederic Weisbecker
2011-09-28 13:53 ` Andrew Vagin
2011-12-08 2:02 ` Arun Sharma
2011-12-09 11:07 ` Andrey Vagin
2011-12-14 20:14 ` Arun Sharma
2011-12-15 15:19 ` Andrew Vagin
2011-12-15 19:08 ` Arun Sharma [this message]
2011-12-16 0:15 ` Arun Sharma
2011-09-26 15:55 ` [PATCH 4/4] events: sched_stat_template saves call chains of a target task Andrew Vagin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EEA45C6.2020106@fb.com \
--to=asharma@fb.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=avagin@gmail.com \
--cc=avagin@openvz.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.