From: Saul Wold <sgw@linux.intel.com>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v3] initscripts: fix timestamp checking at bootmisc.sh
Date: Thu, 15 Dec 2011 11:17:28 -0800 [thread overview]
Message-ID: <4EEA47C8.9030900@linux.intel.com> (raw)
In-Reply-To: <1323844047-16390-1-git-send-email-lauri.hintsala@bluegiga.com>
On 12/13/2011 10:27 PM, Lauri Hintsala wrote:
> Timestamp checking has been broken by the commit
> 2078af333d704fd894a2dedbc19cef5775cdadbb. Currently the RTC time
> is always overwritten with the time from /etc/timestmap. Fix timestamp
> checking and clean the code.
>
> Signed-off-by: Lauri Hintsala<lauri.hintsala@bluegiga.com>
>
> ---
> changes since V2
> * reduce number of forks/execs
> ---
> .../initscripts/initscripts-1.0/bootmisc.sh | 7 +++----
> 1 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/meta/recipes-core/initscripts/initscripts-1.0/bootmisc.sh b/meta/recipes-core/initscripts/initscripts-1.0/bootmisc.sh
> index 03fd67c..ab18ad9 100755
> --- a/meta/recipes-core/initscripts/initscripts-1.0/bootmisc.sh
> +++ b/meta/recipes-core/initscripts/initscripts-1.0/bootmisc.sh
> @@ -62,15 +62,14 @@ then
> fi
>
> # Set the system clock from hardware clock
> -# If the timestamp is 1 day or more recent than the current time,
> +# If the timestamp is more recent than the current time,
> # use the timestamp instead.
> /etc/init.d/hwclock.sh start
> if test -e /etc/timestamp
> then
> - SYSTEMDATE=`date -u +%2m%2d%2H%2M%4Y`
> + SYSTEMDATE=`date -u +%4Y%2m%2d`
> read TIMESTAMP< /etc/timestamp
> - NEEDUPDATE=`expr \( $TIMESTAMP \> $SYSTEMDATE + 10000 \)`
> - if [ $NEEDUPDATE -eq 1 ]; then
> + if [ ${TIMESTAMP#????????}${TIMESTAMP%????????} -gt $SYSTEMDATE ]; then
> date -u $TIMESTAMP
> /etc/init.d/hwclock.sh stop
> fi
Merged into OE-Core
Thanks
Sau!
prev parent reply other threads:[~2011-12-15 19:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-08 7:07 [PATCH] initscripts: fix timestamp check at bootmisc.sh Lauri Hintsala
2011-12-13 6:58 ` [PATCH v2] " Lauri Hintsala
2011-12-13 7:45 ` Koen Kooi
2011-12-13 8:26 ` Lauri Hintsala
2011-12-13 12:26 ` Richard Purdie
2011-12-13 12:36 ` Phil Blundell
2011-12-13 12:58 ` Lauri Hintsala
2011-12-13 13:07 ` Phil Blundell
2011-12-13 13:18 ` Lauri Hintsala
2011-12-13 13:24 ` Phil Blundell
2011-12-13 13:31 ` Henning Heinold
2011-12-13 13:40 ` Lauri Hintsala
2011-12-14 6:27 ` [PATCH v3] initscripts: fix timestamp checking " Lauri Hintsala
2011-12-15 19:17 ` Saul Wold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EEA47C8.9030900@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.