From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:60735)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1RbUrB-0003Qp-1a
	for qemu-devel@nongnu.org; Fri, 16 Dec 2011 05:17:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1RbUr9-0001uu-BO
	for qemu-devel@nongnu.org; Fri, 16 Dec 2011 05:17:37 -0500
Received: from mail-ee0-f45.google.com ([74.125.83.45]:52029)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1RbUr8-0001uh-Ud
	for qemu-devel@nongnu.org; Fri, 16 Dec 2011 05:17:35 -0500
Received: by eekb45 with SMTP id b45so3375580eek.4
	for <qemu-devel@nongnu.org>; Fri, 16 Dec 2011 02:17:34 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4EEB1ABB.50204@redhat.com>
Date: Fri, 16 Dec 2011 11:17:31 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1323721784-704-1-git-send-email-aliguori@us.ibm.com>
	<4EEA3813.80006@us.ibm.com> <4EEB1277.4070803@redhat.com>
In-Reply-To: <4EEB1277.4070803@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 00/20] qom: dynamic properties and
	composition tree
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@us.ibm.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>, Markus Armbruster <armbru@redhat.com>

On 12/16/2011 10:42 AM, Kevin Wolf wrote:
>> >
>> >  Applied.
>> >
>> >  Regards,
>> >
>> >  Anthony Liguori
> So you pushed this with qdev_property_add_child() calls spread all over
> the place instead of being treated like other properties?:-(

I think actually this is not the biggest problem.  child properties are 
dynamic, and it's not a problem IMO if they are created like that.

I don't like that _link_ properties are spread all over the place 
instead of being treated like other properties.  Link properties are 
static, and PROP_PTR properties could often be converted to links.

I'm playing with separating the "legacy" and "static" property concepts 
so that we can head in that direction.  I hope to send out an RFC in an 
hour or so.

Paolo