From: Jens Axboe <axboe@kernel.dk>
To: Shaohua Li <shaohua.li@intel.com>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [patch 1/2]block, cfq: fix empty queue crash caused by request merge
Date: Fri, 16 Dec 2011 13:56:33 +0100 [thread overview]
Message-ID: <4EEB4001.8010205@kernel.dk> (raw)
In-Reply-To: <1324000362.22361.452.camel@sli10-conroe>
On 2011-12-16 02:52, Shaohua Li wrote:
> All requests of a queue could be merged to other requests of other queue.
> Such queue will not have request in it, but it's in service tree. This
> will cause kernel oops.
> I encounter a BUG_ON() in cfq_dispatch_request() with next patch, but the
> issue should exist without the patch.
Good catch, yes I think this could happen if you just happen to have a
very deliberate/unlucky set of processes and timings. Applied.
--
Jens Axboe
prev parent reply other threads:[~2011-12-16 12:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-16 1:52 [patch 1/2]block, cfq: fix empty queue crash caused by request merge Shaohua Li
2011-12-16 12:56 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EEB4001.8010205@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.