From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH] x86/emulator: workaround for AMD erratum 573 Date: Fri, 16 Dec 2011 09:15:59 -0500 Message-ID: <4EEB529F.5010204@amd.com> References: <4EEA33CA.7030906@amd.com> <4EEB0ED402000078000686CE@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4EEB0ED402000078000686CE@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 12/16/11 03:26, Jan Beulich wrote: >>>> On 15.12.11 at 18:52, Boris Ostrovsky wrote: >>> --- a/xen/include/asm-x86/amd.h >>> +++ b/xen/include/asm-x86/amd.h >>> @@ -134,6 +134,12 @@ >>> AMD_OSVW_ERRATUM(3, AMD_MODEL_RANGE(0x10, 0x2, 0x1, 0xff, 0xf), \ >>> AMD_MODEL_RANGE(0x12, 0x0, 0x0, 0x1, 0x0)) >>> >>> +#define AMD_ERRATUM_573 \ >>> + AMD_LEGACY_ERRATUM(AMD_MODEL_RANGE(0x0f, 0x0, 0x0, 0xff, 0xf), \ >>> + AMD_MODEL_RANGE(0x10, 0x0, 0x0, 0xff, 0xf), \ >>> + AMD_MODEL_RANGE(0x11, 0x0, 0x0, 0xff, 0xf), \ >>> + AMD_MODEL_RANGE(0x12, 0x0, 0x0, 0xff, 0xf)) >> >> Families 0xf and 0x11 are not affected by erratum 573. > > Are you saying that these two documents > > 33610 Rev. 3.48 December 2011 > 41788 Rev. 3.10 December 2011 > > both wrong? For fam 0xf it may be that we can set a lower bound for > pre-NPT ones if those indeed are unaffected (but we'd like to be sure > this is the case) - that would appear to be all with a model below 0x40. > > Please clarify. Sorry, my bad. You are right --- somehow I thought it was only 10h and 12h. -boris