From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:43110) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RbZ24-00067Y-WB for qemu-devel@nongnu.org; Fri, 16 Dec 2011 09:45:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RbZ1y-0002vL-CX for qemu-devel@nongnu.org; Fri, 16 Dec 2011 09:45:08 -0500 Received: from mail-iy0-f173.google.com ([209.85.210.173]:36950) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RbZ1y-0002vB-6w for qemu-devel@nongnu.org; Fri, 16 Dec 2011 09:45:02 -0500 Received: by iagj37 with SMTP id j37so5078356iag.4 for ; Fri, 16 Dec 2011 06:45:01 -0800 (PST) Message-ID: <4EEB5969.4090702@codemonkey.ws> Date: Fri, 16 Dec 2011 08:44:57 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1324036918-2405-1-git-send-email-pbonzini@redhat.com> <1324036918-2405-7-git-send-email-pbonzini@redhat.com> <4EEB439F.7010601@redhat.com> <4EEB4CD2.8080907@redhat.com> <4EEB503A.5030706@codemonkey.ws> <4EEB5330.2070605@redhat.com> In-Reply-To: <4EEB5330.2070605@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 6/8] qom: introduce get/set methods for Property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, Gerd Hoffmann , qemu-devel@nongnu.org On 12/16/2011 08:18 AM, Paolo Bonzini wrote: > On 12/16/2011 03:05 PM, Anthony Liguori wrote: >>> >>> I thought the same initially. However, I noticed that the visitor >>> interfaces for >>> links is also a string. So, even if a block/char/netdev property later >>> becomes a >>> link<>, the interface would not change. >> >> The semantics change though. A "drive" link takes a flat block device >> name. When it's converted to a link, it will take a QOM path. Since >> block devices will exist in their own directory, it will certainly still >> be possible to use the flat block device name but since a paths will >> also be supported, I think it's best to clearly distinguish the link >> based property from the flat block device name property. > > But it's a superset, no? My concern is whether you'll get a graceful failure going new->old if you start making use of absolute paths. The type name would change, so I guess that's good enough. Regards, Anthony Liguori > Paolo >