From: Darren Hart <dvhart@linux.intel.com>
To: Koen Kooi <koen@dominion.thruhere.net>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 2/2] dosfstools: Remove initial directory contents feature
Date: Fri, 16 Dec 2011 07:40:08 -0800 [thread overview]
Message-ID: <4EEB6658.7090002@linux.intel.com> (raw)
In-Reply-To: <E0F4AEC8-6105-47AC-B36C-05423970FB7C@dominion.thruhere.net>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 12/15/2011 11:35 PM, Koen Kooi wrote:
>
> Op 16 dec. 2011, om 07:14 heeft Darren Hart het volgende
> geschreven:
>
>> By using mtools, we don't need to continue to maintain and
>> workaround the issues generated by the -d feature included in the
>> OE version of mkdosfstools. This reduces the number of
>> out-of-tree patches we have to carry by 3 and eliminates a rather
>> buggy chunk of code.
>>
>> Drop the initial patch adding -d as well as those applied to
>> improve it and those applied to work around its deficiencies.
>
> The meta-ti BSP layer is depending on the -b behaviour right now
> :(
- -B or -d? I'm removing only -d. If -d, could you use mcopy instead? See
Patch 1/2 for an example of a recursive population of the image using
mcopy. Alternatively, you could bbappend dosfstools in meta-ti to
include these patches. Obviously we don't want to remove it from oe-core
until you do one or the other, but ultimately, I think it's better that
we remove it rather than continue to carry the out-of-tree patches
forward.
Of course, we could try to convince someone to dig in and properly fix
the feature and push to get it upstream - but for licensing reasons,
we'd still be stuck carrying the patches. Since mcopy works properly
as it is, I feel it's the preferable option.
Is anyone else making use of the -d feature?
- --
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQEcBAEBAgAGBQJO62ZFAAoJEKbMaAwKp364kwEIAKcZsX3C9NdzQN10tr0QaAjp
or+ua304+FVlxqsxupUmIA19zm9luAx2xjinmb2Bzuidf2SqBtF/yFXSlMqFGden
YsuiSR83kZPulTxA7oc1VqZ2tD9mfPh3x08mPhNC81ldbpthIjDwOhKg5jyKZS29
FwUOxVzPlG460yoH73K3MiRs0IN+v8cAZTTofPFX3YcibH+hMG73r8KFsG3wHZqp
GsAWRHjQfEcFgYpKMydbv18t3VFNsWNZQFIndV7GPrn0ORHQhT+ctLK9/uin7hh+
g2SJ+BBuAE3fMqSxsW+scn6dYAmx//OBHbMU3PhB7V54aBBVtLJVUfNGoNQwxkw=
=DSZO
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2011-12-16 15:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-16 6:14 [PATCH 0/2] Drop dosfstools -d feature in favor of mtools mcopy Darren Hart
2011-12-16 6:14 ` [PATCH 1/2] bootimg: Use mcopy to construct the hddimg Darren Hart
2011-12-16 16:18 ` Richard Purdie
2011-12-16 6:14 ` [PATCH 2/2] dosfstools: Remove initial directory contents feature Darren Hart
2011-12-16 7:35 ` Koen Kooi
2011-12-16 10:52 ` Richard Purdie
2011-12-16 11:29 ` Koen Kooi
2011-12-16 15:40 ` Darren Hart [this message]
2011-12-16 15:47 ` Darren Hart
2011-12-16 6:36 ` [PATCH 0/2] Drop dosfstools -d feature in favor of mtools mcopy Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EEB6658.7090002@linux.intel.com \
--to=dvhart@linux.intel.com \
--cc=koen@dominion.thruhere.net \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.