From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Fri, 16 Dec 2011 17:18:33 +0100 Subject: [U-Boot] [PATCH V11 11/13] TI: SPL: make SPL available for other SOCs as TI In-Reply-To: References: <1313073896-12952-1-git-send-email-simonschwarzcor@gmail.com> <1324049833-18143-1-git-send-email-sbabic@denx.de> <1324049833-18143-12-git-send-email-sbabic@denx.de> Message-ID: <4EEB6F59.1020607@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 16/12/2011 16:59, Tom Rini wrote: > On Fri, Dec 16, 2011 at 8:37 AM, Stefano Babic wrote: >> The SPL is developped first for TI-OMAPx. The patch >> move OMAP specific function into OMAP directory. > > I wonder if we should fold this into the mv'ing patch as well. I can squash the two patches, but I thought the review is easier as I did. The previous patch shows clearly that the patch was only moved, and the changes in Makefile makes possible to build the boards making the patch bisectable. This patch then > > [snip] >> diff --git a/include/spl.h b/include/spl.h >> +/* Boot type */ >> +#define MMCSD_MODE_UNDEFINED 0 > > Not your bad spacing of course, but please fix. Thanks to have found, I will fix it. > >> +/* NAND SPL functions */ >> +void spl_nand_load_image(void); >> +void spl_arch_nand_init(void); >> + >> +/* MMC SPL functions */ >> +void spl_mmc_load_image(void); > > These should be covered by #ifdef CONFIG_SPL_(NAND||MMC)_SUPPORT Do we need in the header file for the prototypes ? We have never done, and it should be not necessary. Stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================