On 12/16/2011 06:00 PM, Anthony Liguori wrote: > > And perhaps it would make more sense to return Error * and make the > function name be a constructor: > > Error *error_from_qdev_prop_err(int ret, DeviceState *dev, > Property *prop, const char *value); That doesn't work too well when calling it from setters. However, error_set_from_qdev_prop_error is definitely an improvement (no matter what a mouthful it is). I need to rush now. I placed this at git://github.com/qemu/bonzini.git qom-props (commit 263e8c5), so you can play on top of it or pull it. I attach the interdiff from v2. Paolo