From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [PATCH 3.2] KVM: Make KVM_INTEL depend on CPU_SUP_INTEL Date: Fri, 16 Dec 2011 10:26:49 -0800 Message-ID: <4EEB8D69.3040003@xenotime.net> References: <1323858467-23537-1-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org, Ingo Molnar To: Avi Kivity Return-path: Received: from oproxy6-pub.bluehost.com ([67.222.54.6]:50222 "HELO oproxy6-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753457Ab1LPR0l (ORCPT ); Fri, 16 Dec 2011 12:26:41 -0500 In-Reply-To: <1323858467-23537-1-git-send-email-avi@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 12/14/2011 02:27 AM, Avi Kivity wrote: > PMU virtualization needs to talk to Intel-specific bits of perf; these are > only available when CPU_SUP_INTEL=y. > > Fixes > > arch/x86/built-in.o: In function `atomic_switch_perf_msrs': > vmx.c:(.text+0x6b1d4): undefined reference to `perf_guest_get_msrs' > > Reported-by: Ingo Molnar > Reported-by: Randy Dunlap > Signed-off-by: Avi Kivity Acked-by: Randy Dunlap Thanks. > --- > arch/x86/kvm/Kconfig | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig > index ff5790d..ca4d49e 100644 > --- a/arch/x86/kvm/Kconfig > +++ b/arch/x86/kvm/Kconfig > @@ -52,6 +52,8 @@ config KVM > config KVM_INTEL > tristate "KVM for Intel processors support" > depends on KVM > + # for perf_guest_get_msrs(): > + depends on CPU_SUP_INTEL > ---help--- > Provides support for KVM on Intel processors equipped with the VT > extensions. -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***