From: Mike Christie <michaelc@cs.wisc.edu>
To: vikas.chaudhary@qlogic.com
Cc: jbottomley@parallels.com, linux-scsi@vger.kernel.org,
lalit.chandivade@qlogic.com, ravi.anand@qlogic.com
Subject: Re: [PATCH 0/5] qla4xxx: Patches for scsi-misc
Date: Fri, 16 Dec 2011 15:14:05 -0600 [thread overview]
Message-ID: <4EEBB49D.3010302@cs.wisc.edu> (raw)
In-Reply-To: <1324029539-26021-1-git-send-email-vikas.chaudhary@qlogic.com>
On 12/16/2011 03:58 AM, vikas.chaudhary@qlogic.com wrote:
> From: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
>
> James,
>
> Please apply the following patches to scsi-misc for inclusion in mainline.
>
> Lalit Chandivade (1):
> qla4xxx: cleanup, make qla4xxx_build_ddb_list short
>
> Manish Rangankar (1):
> qla4xxx: Fixed BFS with sendtargets as boot index.
>
> Nilesh Javali (2):
> qla4xxx: Limit the ACB Default Timeout value to 12s
> qla4xxx: Break the loop if the sendtargets list was empty
>
> Vikas Chaudhary (1):
> qla4xxx: Update driver version to 5.02.00-k11
>
> drivers/scsi/qla4xxx/ql4_os.c | 419 +++++++++++++++++++++--------------
> drivers/scsi/qla4xxx/ql4_version.h | 2 +-
> 2 files changed, 252 insertions(+), 169 deletions(-)
>
Looks ok, but I think in some patches descriptions in the future you
should add a better description. In the 2nd patch there is no info about
if it fixes a bug or why you are doing it. We do not know what the JIRA
value is about.
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
next prev parent reply other threads:[~2011-12-16 21:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-16 9:58 [PATCH 0/5] qla4xxx: Patches for scsi-misc vikas.chaudhary
2011-12-16 9:58 ` [PATCH 1/5] qla4xxx: cleanup, make qla4xxx_build_ddb_list short vikas.chaudhary
2011-12-16 9:58 ` [PATCH 2/5] qla4xxx: Limit the ACB Default Timeout value to 12s vikas.chaudhary
2011-12-16 21:18 ` James Bottomley
2011-12-19 5:51 ` Vikas Chaudhary
2011-12-16 9:58 ` [PATCH 3/5] qla4xxx: Break the loop if the sendtargets list was empty vikas.chaudhary
2011-12-16 9:58 ` [PATCH 4/5] qla4xxx: Fixed BFS with sendtargets as boot index vikas.chaudhary
2011-12-16 9:58 ` [PATCH 5/5] qla4xxx: Update driver version to 5.02.00-k11 vikas.chaudhary
2011-12-16 21:14 ` Mike Christie [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-01-19 11:06 [PATCH 0/5] qla4xxx: Patches for scsi-misc vikas.chaudhary
2012-01-19 12:37 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EEBB49D.3010302@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=jbottomley@parallels.com \
--cc=lalit.chandivade@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
--cc=ravi.anand@qlogic.com \
--cc=vikas.chaudhary@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.