Re: [PATCH] scsi_dh_rdac: Fix error path

[Richard Weinberger <richard@nod.at>]

[-- Attachment #1: Type: text/plain, Size: 1302 bytes --]

Am 18.11.2011 15:34, schrieb Moger, Babu:
> Looks good to me..
> 
>> -----Original Message-----
>> From: Richard Weinberger [mailto:richard@nod.at]
>> Sent: Thursday, November 17, 2011 6:44 PM
>> To: JBottomley@parallels.com
>> Cc: Moger, Babu; Somasundaram.Krishnasamy@lsi.com; yanling.qi@lsi.com;
>> linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; Richard
>> Weinberger
>> Subject: [PATCH] scsi_dh_rdac: Fix error path
>>
>> If create_singlethread_workqueue() failes, rdac_init should fail too.
>>
>> Signed-off-by: Richard Weinberger <richard@nod.at>
>> ---
>>  drivers/scsi/device_handler/scsi_dh_rdac.c |    2 ++
>>  1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/scsi/device_handler/scsi_dh_rdac.c
>> b/drivers/scsi/device_handler/scsi_dh_rdac.c
>> index 1d31279..2802394 100644
>> --- a/drivers/scsi/device_handler/scsi_dh_rdac.c
>> +++ b/drivers/scsi/device_handler/scsi_dh_rdac.c
>> @@ -934,6 +934,8 @@ static int __init rdac_init(void)
>>  	if (!kmpath_rdacd) {
>>  		scsi_unregister_device_handler(&rdac_dh);
>>  		printk(KERN_ERR "kmpath_rdacd creation failed.\n");
>> +
>> +		r = -EINVAL;
>>  	}
>>  done:
>>  	return r;
>> --
>> 1.7.7.3
> 

James,

can you please pickup this patch?

Thanks,
//richard



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]