From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
To: Tatsunosuke Tobita <junkpainting@gmail.com>
Cc: linux-input@vger.kernel.org,
Tatsunosuke Tobita <tobita.tatsunosuke@wacom.co.jp>,
dmitry.torokhov@gmail.com
Subject: Re: [PATCH] Adding Wacom I2C stylus support
Date: Mon, 19 Dec 2011 13:22:38 +0800 [thread overview]
Message-ID: <4EEECA1E.7050103@cn.fujitsu.com> (raw)
In-Reply-To: <1324271114-25673-1-git-send-email-tobita.tatsunosuke@wacom.co.jp>
On 12/19/2011 01:05 PM, Tatsunosuke Tobita wrote:
> From: Tatsunosuke Tobita <tobita.tatsunosuke@wacom.co.jp>
>
>
At least, add a short comment here?
> Signed-off-by: Tatsunosuke Tobita <tobita.tatsunosuke@wacom.co.jp>
> ---
> drivers/input/touchscreen/Kconfig | 11 +++++++++++
> drivers/input/touchscreen/Makefile | 2 ++
> 2 files changed, 13 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
> index 3488ffe..cae448e 100644
> --- a/drivers/input/touchscreen/Kconfig
> +++ b/drivers/input/touchscreen/Kconfig
> @@ -738,4 +738,15 @@ config TOUCHSCREEN_TPS6507X
> To compile this driver as a module, choose M here: the
> module will be called tps6507x_ts.
>
> +config TOUCHSCREEN_WACOM_I2C
> + tristate "Wacom Tablet support(I2C)"
> + depends on I2C
> + help
> + Say Y here if you want to use the I2C version of the Wacom Pen.
> + Make sure to say Y to "Mouse support" (CONFIG_INPUT_MOUSEDEV)
> + and/or "Event interface support" (CONFIG_INPUT_EVDEV) as well.
> +
> + To compile this driver as a module, choose M here: the module
> + will be called wacom_i2c.
> +
> endif
> diff --git a/drivers/input/touchscreen/Makefile b/drivers/input/touchscreen/Makefile
> index f957676..216dd57 100644
> --- a/drivers/input/touchscreen/Makefile
> +++ b/drivers/input/touchscreen/Makefile
> @@ -5,6 +5,7 @@
> # Each configuration option enables a list of files.
>
> wm97xx-ts-y := wm97xx-core.o
> +wacom_i2c-ts-objs := wacom_i2c_func.o wacom_i2c.o
Why do you add this line? or if I missed something?
Thanks
-Wanlong Gao
>
> obj-$(CONFIG_TOUCHSCREEN_88PM860X) += 88pm860x-ts.o
> obj-$(CONFIG_TOUCHSCREEN_AD7877) += ad7877.o
> @@ -61,3 +62,4 @@ obj-$(CONFIG_TOUCHSCREEN_WM97XX_MAINSTONE) += mainstone-wm97xx.o
> obj-$(CONFIG_TOUCHSCREEN_WM97XX_ZYLONITE) += zylonite-wm97xx.o
> obj-$(CONFIG_TOUCHSCREEN_W90X900) += w90p910_ts.o
> obj-$(CONFIG_TOUCHSCREEN_TPS6507X) += tps6507x-ts.o
> +obj-$(CONFIG_TOUCHSCREEN_WACOM_I2C) += wacom_i2c-ts.o
prev parent reply other threads:[~2011-12-19 5:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-19 5:05 [PATCH] Adding Wacom I2C stylus support Tatsunosuke Tobita
2011-12-19 5:22 ` Wanlong Gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EEECA1E.7050103@cn.fujitsu.com \
--to=gaowanlong@cn.fujitsu.com \
--cc=dmitry.torokhov@gmail.com \
--cc=junkpainting@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=tobita.tatsunosuke@wacom.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.