All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg@grandegger.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ehci: speed up initialization
Date: Mon, 19 Dec 2011 13:07:39 +0100	[thread overview]
Message-ID: <4EEF290B.9060106@grandegger.com> (raw)
In-Reply-To: <CANqCtQKsYV=mbxHRDKYF2QoiF33V=LiiAPeDd1a6XsgVzR5=4g@mail.gmail.com>

On 12/10/2011 05:29 PM, Remy Bohmer wrote:
> Hi,
> 
> 2011/12/5 Vincent Palatin <vpalatin@chromium.org>:
>> According to EHCI specification v1.0, the controller should stabilize
>> the power on a port at most 20 ms after the port power bit transition.
>> So, we put this setting in the virtual descriptor corresponding field,
>> (bPwrOn2PwrGood = 10 => 10 x 2ms = 20ms), this saves about 500ms at each
>> controller initialization/enumeration.
>>
>> Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
>> ---
>>  drivers/usb/host/ehci-hcd.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> Applied to u-boot-usb.

I just realized that this patch breaks "usb start" on my mx53loco board:

  MX53LOCO U-Boot > usb start
  (Re)start USB...
  USB:   Register 10011 NbrPorts 1
  USB EHCI 1.00
  scanning bus for devices... 1 USB Device(s) found
         scanning bus for storage devices... 0 Storage Device(s) found
         scanning bus for ethernet devices... 0 Ethernet Device(s) found

  MX53LOCO U-Boot > usb start
  (Re)start USB...
  USB:   Register 10011 NbrPorts 1
  USB EHCI 1.00
  scanning bus for devices... 2 USB Device(s) found
         scanning bus for storage devices... 0 Storage Device(s) found
         scanning bus for ethernet devices... 1 Ethernet Device(s) found

The device is not found at the first attempt. Obviously, a value of 10
for bPwrOn2PwrGood seems too short but 20 works fine. Would that be a
resonable compromise? If yes, I could send a patch.

Wolfgang.

Wolfgang.

  reply	other threads:[~2011-12-19 12:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-05 22:52 [U-Boot] [PATCH] ehci: speed up initialization Vincent Palatin
2011-12-10 16:29 ` Remy Bohmer
2011-12-19 12:07   ` Wolfgang Grandegger [this message]
2011-12-19 12:51     ` Vincent Palatin
2011-12-19 13:31       ` Wolfgang Grandegger
2011-12-19 16:59         ` Remy Bohmer
2011-12-19 18:18           ` Vincent Palatin
2011-12-20 16:10           ` Wolfgang Grandegger
2011-12-19 15:32     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EEF290B.9060106@grandegger.com \
    --to=wg@grandegger.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.