From mboxrd@z Thu Jan 1 00:00:00 1970 From: b-cousson@ti.com (Cousson, Benoit) Date: Mon, 19 Dec 2011 13:41:52 +0100 Subject: [PATCH 2/9] irq: check domain hwirq range for DT translate In-Reply-To: <1323876538-20406-3-git-send-email-robherring2@gmail.com> References: <1323876538-20406-1-git-send-email-robherring2@gmail.com> <1323876538-20406-3-git-send-email-robherring2@gmail.com> Message-ID: <4EEF3110.30203@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Rob, While trying your series to take advantage of the generic-irq domain support for OMAP3 INTC, I realized that the following patch is breaking drivers that are using irq_domain_add_simple. The point is that irq_domain_add_simple does not populate hwirq_base or nr_irq, so that test will always fail if the domain is created by the irq_domain_add_simple API. Adding an extra parameter to provide the nr_irq should fix that. The long term fix should be to use the generic-irq for such driver, but this is not the same effort, so it might worth fixing that API for the moment. Regards, Benoit On 12/14/2011 4:28 PM, Rob Herring wrote: > From: Rob Herring > > A DT node may have more than 1 domain associated with it, so make sure > the hwirq number is within range when doing DT translation. > > Signed-off-by: Rob Herring > Cc: Thomas Gleixner > --- > kernel/irq/irqdomain.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c > index 200ce83..ae6441e 100644 > --- a/kernel/irq/irqdomain.c > +++ b/kernel/irq/irqdomain.c > @@ -135,6 +135,9 @@ int irq_domain_simple_dt_translate(struct irq_domain *d, > return -EINVAL; > if (intsize< 1) > return -EINVAL; > + if ((intspec[0]< d->hwirq_base) || > + (intspec[0]>= d->hwirq_base + d->nr_irq)) > + return -EINVAL; > > *out_hwirq = intspec[0]; > *out_type = IRQ_TYPE_NONE; From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Cousson, Benoit" Subject: Re: [PATCH 2/9] irq: check domain hwirq range for DT translate Date: Mon, 19 Dec 2011 13:41:52 +0100 Message-ID: <4EEF3110.30203@ti.com> References: <1323876538-20406-1-git-send-email-robherring2@gmail.com> <1323876538-20406-3-git-send-email-robherring2@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1323876538-20406-3-git-send-email-robherring2@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree-discuss@lists.ozlabs.org, Kevin Hilman , Kukjin Kim , Tony Lindgren , Linus Walleij , Rob Herring , Barry Song , Thomas Gleixner List-Id: devicetree@vger.kernel.org Hi Rob, While trying your series to take advantage of the generic-irq domain support for OMAP3 INTC, I realized that the following patch is breaking drivers that are using irq_domain_add_simple. The point is that irq_domain_add_simple does not populate hwirq_base or nr_irq, so that test will always fail if the domain is created by the irq_domain_add_simple API. Adding an extra parameter to provide the nr_irq should fix that. The long term fix should be to use the generic-irq for such driver, but this is not the same effort, so it might worth fixing that API for the moment. Regards, Benoit On 12/14/2011 4:28 PM, Rob Herring wrote: > From: Rob Herring > > A DT node may have more than 1 domain associated with it, so make sure > the hwirq number is within range when doing DT translation. > > Signed-off-by: Rob Herring > Cc: Thomas Gleixner > --- > kernel/irq/irqdomain.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c > index 200ce83..ae6441e 100644 > --- a/kernel/irq/irqdomain.c > +++ b/kernel/irq/irqdomain.c > @@ -135,6 +135,9 @@ int irq_domain_simple_dt_translate(struct irq_domain *d, > return -EINVAL; > if (intsize< 1) > return -EINVAL; > + if ((intspec[0]< d->hwirq_base) || > + (intspec[0]>= d->hwirq_base + d->nr_irq)) > + return -EINVAL; > > *out_hwirq = intspec[0]; > *out_type = IRQ_TYPE_NONE; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752716Ab1LSMm1 (ORCPT ); Mon, 19 Dec 2011 07:42:27 -0500 Received: from devils.ext.ti.com ([198.47.26.153]:36435 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751866Ab1LSMmY (ORCPT ); Mon, 19 Dec 2011 07:42:24 -0500 Message-ID: <4EEF3110.30203@ti.com> Date: Mon, 19 Dec 2011 13:41:52 +0100 From: "Cousson, Benoit" Organization: Texas Instruments User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:8.0) Gecko/20111105 Thunderbird/8.0 MIME-Version: 1.0 To: Rob Herring CC: , , , Kevin Hilman , Kukjin Kim , Tony Lindgren , Linus Walleij , Rob Herring , Barry Song , Thomas Gleixner Subject: Re: [PATCH 2/9] irq: check domain hwirq range for DT translate References: <1323876538-20406-1-git-send-email-robherring2@gmail.com> <1323876538-20406-3-git-send-email-robherring2@gmail.com> In-Reply-To: <1323876538-20406-3-git-send-email-robherring2@gmail.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, While trying your series to take advantage of the generic-irq domain support for OMAP3 INTC, I realized that the following patch is breaking drivers that are using irq_domain_add_simple. The point is that irq_domain_add_simple does not populate hwirq_base or nr_irq, so that test will always fail if the domain is created by the irq_domain_add_simple API. Adding an extra parameter to provide the nr_irq should fix that. The long term fix should be to use the generic-irq for such driver, but this is not the same effort, so it might worth fixing that API for the moment. Regards, Benoit On 12/14/2011 4:28 PM, Rob Herring wrote: > From: Rob Herring > > A DT node may have more than 1 domain associated with it, so make sure > the hwirq number is within range when doing DT translation. > > Signed-off-by: Rob Herring > Cc: Thomas Gleixner > --- > kernel/irq/irqdomain.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c > index 200ce83..ae6441e 100644 > --- a/kernel/irq/irqdomain.c > +++ b/kernel/irq/irqdomain.c > @@ -135,6 +135,9 @@ int irq_domain_simple_dt_translate(struct irq_domain *d, > return -EINVAL; > if (intsize< 1) > return -EINVAL; > + if ((intspec[0]< d->hwirq_base) || > + (intspec[0]>= d->hwirq_base + d->nr_irq)) > + return -EINVAL; > > *out_hwirq = intspec[0]; > *out_type = IRQ_TYPE_NONE;