From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Tobias Schandinat Date: Mon, 19 Dec 2011 15:18:04 +0000 Subject: Re: [PATCH] MXSFB: Fix driver registration Message-Id: <4EEF55AC.6060107@gmx.de> List-Id: References: <1324169888-6687-1-git-send-email-marek.vasut@gmail.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Shawn Guo Cc: Marek Vasut , linux-kernel@vger.kernel.org, Wolfgang Denk , Stefano Babic , Huang Shijie , Axel Lin , Sascha Hauer , linux-fbdev@vger.kernel.org Hi Marek, can you please resend the patch to me and the fbdev mailing list, preferably with all Ack's you received until now included. On 12/19/2011 01:51 PM, Shawn Guo wrote: > Cc-ed Florian and linux-fbdev@vger.kernel.org, as I guess Florian is > the person who will take this patch. Thanks, I will. I guess you wanted to Ack this patch? Thanks, Florian Tobias Schandinat > > -- Regards,Shawn > On 18 December 2011 08:58, Marek Vasut wrote: >> The driver should be registered with mxsfb_driver, not with mxsfb_devtype. >> This caused obvious null pointer dereference and crash. >> >> Signed-off-by: Marek Vasut >> Cc: Wolfgang Denk >> Cc: Stefano Babic >> Cc: Shawn Guo >> Cc: Huang Shijie >> Cc: Axel Lin >> Cc: Sascha Hauer >> --- >> drivers/video/mxsfb.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c >> index 18742c2..d29c7c0 100644 >> --- a/drivers/video/mxsfb.c >> +++ b/drivers/video/mxsfb.c >> @@ -902,7 +902,7 @@ static struct platform_driver mxsfb_driver = { >> }, >> }; >> >> -module_platform_driver(mxsfb_devtype); >> +module_platform_driver(mxsfb_driver); >> >> MODULE_DESCRIPTION("Freescale mxs framebuffer driver"); >> MODULE_AUTHOR("Sascha Hauer, Pengutronix"); >> -- >> 1.7.6.4 >> >