From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:38753) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RcfEH-0003z8-OJ for qemu-devel@nongnu.org; Mon, 19 Dec 2011 10:34:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RcfEG-0001eN-LN for qemu-devel@nongnu.org; Mon, 19 Dec 2011 10:34:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:2560) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RcfEG-0001eB-Ef for qemu-devel@nongnu.org; Mon, 19 Dec 2011 10:34:16 -0500 Message-ID: <4EEF5974.4080608@redhat.com> Date: Mon, 19 Dec 2011 17:34:12 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1323956131-471-1-git-send-email-avi@redhat.com> <4EEF51E5.6070700@codemonkey.ws> <4EEF52DC.6080301@redhat.com> In-Reply-To: <4EEF52DC.6080301@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 0/2] Plan obsolescense of exec.c memory functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org On 12/19/2011 05:06 PM, Avi Kivity wrote: > On 12/19/2011 05:01 PM, Anthony Liguori wrote: > > On 12/15/2011 07:35 AM, Avi Kivity wrote: > >> Exile some exec.c functions to a private header, to prevent > >> accidental reuse. > >> > >> Please pull from > >> > >> git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git > >> memory/exec-obsolete > > > > This breaks the Xen build. Perhaps we need to merge your patches to > > convert Xen to the memory API first? > > > > cc1: warnings being treated as errors > > /home/anthony/git/qemu/xen-all.c: In function =91xen_ram_init=92: > > /home/anthony/git/qemu/xen-all.c:169:5: error: implicit declaration o= f > > function =91cpu_register_physical_memory=92 > > /home/anthony/git/qemu/xen-all.c:169:5: error: nested extern > > declaration of =91cpu_register_physical_memory=92 > > make[1]: *** [xen-all.o] Error 1 > > Yeah, I'll redo and repost. > It's now in the memory/xen and memory/exec-obsolete branches of qemu-kvm.git (latter based on the former). --=20 error compiling committee.c: too many arguments to function