From: David Ahern <dsahern@gmail.com>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Andrew Vagin <avagin@gmail.com>, Andrew Vagin <avagin@openvz.org>,
linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl,
paulus@samba.org, mingo@elte.hu, asharma@fb.com,
devel@openvz.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 3/6] perf: add ability to record event period
Date: Mon, 19 Dec 2011 14:25:45 -0700 [thread overview]
Message-ID: <4EEFABD9.9050203@gmail.com> (raw)
In-Reply-To: <20111219205829.GB28058@infradead.org>
On 12/19/2011 01:58 PM, Arnaldo Carvalho de Melo wrote:
> I get that Arun is in agreement, everything seems OK, but we need to do
> a better job on describing why we add code, the context we have now from
> all these discussions will be mostly lost, say, 5 years from now when we
> try to figure out why something was done in some way,
It seems like an option is needed for all the sample attributes.
Timestamp is now covered (-T). Sample address is covered (-d). Callchain
(-g). This targets period (-P). I think that just leaves CPU, and we are
out of c/C options. ;-)
David
next prev parent reply other threads:[~2011-12-19 21:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-07 13:55 [PATCH 0/7] Profiling sleep times (v4) Andrew Vagin
2011-12-07 13:55 ` [PATCH 1/6] perf: use event_name() to get an event name Andrew Vagin
2011-12-07 13:55 ` [PATCH 2/6] perf: add ability to change event according to sample (v3) Andrew Vagin
2011-12-12 17:35 ` [tip:perf/core] perf tools: Add ability to synthesize event according to a sample tip-bot for Andrew Vagin
2011-12-07 13:55 ` [PATCH 3/6] perf: add ability to record event period Andrew Vagin
2011-12-16 7:13 ` Andrew Vagin
2011-12-19 19:20 ` Arun Sharma
2011-12-19 19:20 ` Arun Sharma
2011-12-19 20:58 ` Arnaldo Carvalho de Melo
2011-12-19 21:25 ` David Ahern [this message]
2011-12-20 8:07 ` Andrew Vagin
2011-12-20 10:17 ` Peter Zijlstra
2011-12-20 13:26 ` Arnaldo Carvalho de Melo
2011-12-07 13:55 ` [PATCH 4/6] perf: teach "perf inject" to work with files Andrew Vagin
2011-12-07 13:56 ` [PATCH 5/6] perf: teach perf inject to merge sched_stat_* and sched_switch events Andrew Vagin
2011-12-07 13:56 ` [PATCH 6/6] perf: add scripts for profiling sleep times (v2) Andrew Vagin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EEFABD9.9050203@gmail.com \
--to=dsahern@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=asharma@fb.com \
--cc=avagin@gmail.com \
--cc=avagin@openvz.org \
--cc=devel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.