From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takuya Yoshikawa Subject: Re: [PATCH 2/3] KVM: MMU: Add missing large page accounting to drop_large_spte() Date: Tue, 20 Dec 2011 13:37:23 +0900 Message-ID: <4EF01103.4060702@oss.ntt.co.jp> References: <20111129140147.c6b5a8f9.yoshikawa.takuya@oss.ntt.co.jp> <20111129140336.6e84d840.yoshikawa.takuya@oss.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, takuya.yoshikawa@gmail.com To: avi@redhat.com, mtosatti@redhat.com Return-path: Received: from serv2.oss.ntt.co.jp ([222.151.198.100]:50698 "EHLO serv2.oss.ntt.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752269Ab1LTEgY (ORCPT ); Mon, 19 Dec 2011 23:36:24 -0500 In-Reply-To: <20111129140336.6e84d840.yoshikawa.takuya@oss.ntt.co.jp> Sender: kvm-owner@vger.kernel.org List-ID: ping (2011/11/29 14:03), Takuya Yoshikawa wrote: > Signed-off-by: Takuya Yoshikawa > --- > arch/x86/kvm/mmu.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c > index 09da963..5e761ff 100644 > --- a/arch/x86/kvm/mmu.c > +++ b/arch/x86/kvm/mmu.c > @@ -1803,6 +1803,7 @@ static void drop_large_spte(struct kvm_vcpu *vcpu, u64 *sptep) > { > if (is_large_pte(*sptep)) { > drop_spte(vcpu->kvm, sptep); > + --vcpu->kvm->stat.lpages; > kvm_flush_remote_tlbs(vcpu->kvm); > } > } Is this fix wrong? I do not mind dropping other two cleanups in the patch set if you do not like; of course I will update this if needed. Takuya