From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: Tegra: Fix Harmony and Ventana builds
Date: Tue, 20 Dec 2011 07:55:43 +0100 [thread overview]
Message-ID: <4EF0316F.1080100@aribaud.net> (raw)
In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF176BE92C09@HQMAIL01.nvidia.com>
Hi all,
Le 20/12/2011 01:06, Stephen Warren a ?crit :
> Tom Warren wrote at Monday, December 19, 2011 4:09 PM:
>> Signed-off-by: Tom Warren<twarren@nvidia.com>
>>
>> BUG=none
>> TEST=built all 3 (Harmony, Seaboard and Ventana) and tested Seaboard
>
> Tom,
>
> I'm a little confused by this. The patch removes ../common/board.o from
> COBJS for Harmony and Ventana, but not from Seaboard, and at least in
> u-boot-tegra/ next, Seaboard still references that file.
>
> Also, applying this patch causes Harmony and Ventana to fail to build
> (link) due to undefined symbols typically provided by common/board.o.
>
> What branch is the patch targeted at, and what build problems is it
> solving?
Plus, I would suggest making the commit message less cryptic; I can make
no heads or tails of these "BUG=" and "TEST=" lines.
Amicalement,
--
Albert.
next prev parent reply other threads:[~2011-12-20 6:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-19 23:08 [U-Boot] [PATCH] arm: Tegra: Fix Harmony and Ventana builds Tom Warren
2011-12-20 0:06 ` Stephen Warren
2011-12-20 6:55 ` Albert ARIBAUD [this message]
2011-12-20 17:21 ` Tom Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF0316F.1080100@aribaud.net \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.