From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Cousson, Benoit" Subject: Re: [PATCH 3/3] ARM: OMAP2+: board-generic: Replace #if defined by #ifdef for consistency Date: Tue, 20 Dec 2011 14:20:11 +0100 Message-ID: <4EF08B8B.2040400@ti.com> References: <1323190149-6492-4-git-send-email-b-cousson@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from arroyo.ext.ti.com ([192.94.94.40]:47544 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751224Ab1LTNUd (ORCPT ); Tue, 20 Dec 2011 08:20:33 -0500 In-Reply-To: <1323190149-6492-4-git-send-email-b-cousson@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Benoit Cousson Cc: tony@atomide.com, devicetree-discuss@lists.ozlabs.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Hi Tony, What about that patch? This is the only one that is missing in lo. I know it is not a big deal, but it will make things a little bit cleaner. Thanks, Benoit On 12/6/2011 5:49 PM, Benoit Cousson wrote: > The file contains a mix of #ifdef and #if defined(). > Replace the #if... by #ifdef. > > Signed-off-by: Benoit Cousson > Cc: Tony Lindgren > --- > arch/arm/mach-omap2/board-generic.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/mach-omap2/board-generic.c b/arch/arm/mach-omap2/board-generic.c > index fb55fa3..09f44e0 100644 > --- a/arch/arm/mach-omap2/board-generic.c > +++ b/arch/arm/mach-omap2/board-generic.c > @@ -92,7 +92,7 @@ static void __init omap3_init(void) > } > #endif > > -#if defined(CONFIG_SOC_OMAP2420) > +#ifdef CONFIG_SOC_OMAP2420 > static const char *omap242x_boards_compat[] __initdata = { > "ti,omap2420", > NULL, > @@ -110,7 +110,7 @@ DT_MACHINE_START(OMAP242X_DT, "Generic OMAP2420 (Flattened Device Tree)") > MACHINE_END > #endif > > -#if defined(CONFIG_SOC_OMAP2430) > +#ifdef CONFIG_SOC_OMAP2430 > static const char *omap243x_boards_compat[] __initdata = { > "ti,omap2430", > NULL, > @@ -128,7 +128,7 @@ DT_MACHINE_START(OMAP243X_DT, "Generic OMAP2430 (Flattened Device Tree)") > MACHINE_END > #endif > > -#if defined(CONFIG_ARCH_OMAP3) > +#ifdef CONFIG_ARCH_OMAP3 > static const char *omap3_boards_compat[] __initdata = { > "ti,omap3", > NULL, > @@ -146,7 +146,7 @@ DT_MACHINE_START(OMAP3_DT, "Generic OMAP3 (Flattened Device Tree)") > MACHINE_END > #endif > > -#if defined(CONFIG_ARCH_OMAP4) > +#ifdef CONFIG_ARCH_OMAP4 > static const char *omap4_boards_compat[] __initdata = { > "ti,omap4", > NULL, From mboxrd@z Thu Jan 1 00:00:00 1970 From: b-cousson@ti.com (Cousson, Benoit) Date: Tue, 20 Dec 2011 14:20:11 +0100 Subject: [PATCH 3/3] ARM: OMAP2+: board-generic: Replace #if defined by #ifdef for consistency In-Reply-To: <1323190149-6492-4-git-send-email-b-cousson@ti.com> References: <1323190149-6492-4-git-send-email-b-cousson@ti.com> Message-ID: <4EF08B8B.2040400@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Tony, What about that patch? This is the only one that is missing in lo. I know it is not a big deal, but it will make things a little bit cleaner. Thanks, Benoit On 12/6/2011 5:49 PM, Benoit Cousson wrote: > The file contains a mix of #ifdef and #if defined(). > Replace the #if... by #ifdef. > > Signed-off-by: Benoit Cousson > Cc: Tony Lindgren > --- > arch/arm/mach-omap2/board-generic.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/mach-omap2/board-generic.c b/arch/arm/mach-omap2/board-generic.c > index fb55fa3..09f44e0 100644 > --- a/arch/arm/mach-omap2/board-generic.c > +++ b/arch/arm/mach-omap2/board-generic.c > @@ -92,7 +92,7 @@ static void __init omap3_init(void) > } > #endif > > -#if defined(CONFIG_SOC_OMAP2420) > +#ifdef CONFIG_SOC_OMAP2420 > static const char *omap242x_boards_compat[] __initdata = { > "ti,omap2420", > NULL, > @@ -110,7 +110,7 @@ DT_MACHINE_START(OMAP242X_DT, "Generic OMAP2420 (Flattened Device Tree)") > MACHINE_END > #endif > > -#if defined(CONFIG_SOC_OMAP2430) > +#ifdef CONFIG_SOC_OMAP2430 > static const char *omap243x_boards_compat[] __initdata = { > "ti,omap2430", > NULL, > @@ -128,7 +128,7 @@ DT_MACHINE_START(OMAP243X_DT, "Generic OMAP2430 (Flattened Device Tree)") > MACHINE_END > #endif > > -#if defined(CONFIG_ARCH_OMAP3) > +#ifdef CONFIG_ARCH_OMAP3 > static const char *omap3_boards_compat[] __initdata = { > "ti,omap3", > NULL, > @@ -146,7 +146,7 @@ DT_MACHINE_START(OMAP3_DT, "Generic OMAP3 (Flattened Device Tree)") > MACHINE_END > #endif > > -#if defined(CONFIG_ARCH_OMAP4) > +#ifdef CONFIG_ARCH_OMAP4 > static const char *omap4_boards_compat[] __initdata = { > "ti,omap4", > NULL,