From: Arun Sharma <asharma@fb.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Arnaldo Carvalho de Melo <acme@infradead.org>,
Andrew Vagin <avagin@openvz.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 2/2] tracing, sched: Add a new tracepoint for sleeptime
Date: Tue, 20 Dec 2011 10:22:26 -0800 [thread overview]
Message-ID: <4EF0D262.5000405@fb.com> (raw)
In-Reply-To: <1324404995.5916.66.camel@gandalf.stny.rr.com>
On 12/20/11 10:16 AM, Steven Rostedt wrote:
>> +#ifdef CREATE_TRACE_POINTS
>
> Why the #ifdef? a static inline is fine to keep in the open. If nothing
> uses it, then it just wont be used or defined.
>
Without the ifdef I get:
In file included from include/trace/define_trace.h:80,
from include/trace/events/sched.h:445,
from kernel/sched/core.c:86:
include/trace/events/sched.h:366: error: redefinition of
‘trace_get_sleeptime’
include/trace/events/sched.h:366: note: previous definition of
‘trace_get_sleeptime’ was here
So I shamelessly copied what the other static inline function in the
file does.
I also noticed that sched_stat_sleeptime() is very similar to
sched_stat_sleep(). The latter covers sleeps but not iowait and doesn't
include the scheduler latency. Let me know if you think this is a show
stopper that needs a rename.
-Arun
next prev parent reply other threads:[~2011-12-20 18:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-20 18:09 [PATCH 0/2] Sleep Profiling v2 Arun Sharma
2011-12-20 18:09 ` [PATCH 1/2] sched: Retain sleep/block information Arun Sharma
2011-12-20 18:09 ` [PATCH 2/2] tracing, sched: Add a new tracepoint for sleeptime Arun Sharma
2011-12-20 18:16 ` Steven Rostedt
2011-12-20 18:22 ` Arun Sharma [this message]
2011-12-20 19:19 ` Steven Rostedt
2011-12-21 10:43 ` Andrey Vagin
2011-12-22 0:18 ` Arun Sharma
2012-01-19 22:30 ` Arun Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF0D262.5000405@fb.com \
--to=asharma@fb.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@infradead.org \
--cc=avagin@openvz.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.