All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ilya Yanok <yanok@emcraft.com>
To: Simon Budig <simon.budig@kernelconcepts.de>
Cc: agust@denx.de, linux-input@vger.kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH v2] Touchscreen driver for FT5x06 based EDT displays
Date: Wed, 21 Dec 2011 02:47:31 +0400	[thread overview]
Message-ID: <4EF11083.8050100@emcraft.com> (raw)
In-Reply-To: <4EE9F927.7070609@kernelconcepts.de>

Hi Simon,

On 15.12.2011 17:41, Simon Budig wrote:
> If I am not supposed to use irq_to_gpio, then how do I solve this?
> 
> * expect the board file to set up the resp. GPIO direction?

If you don't need GPIO number for anything else (e.g. reading GPIO state
manually) I'd go that way. This introduces a bit of code duplication as
Anatolij already said but I think this is acceptable. If your code wants
IRQ number than pass IRQ number to it. I can't see any reason for the
driver to "know" that IRQ comes from GPIO.

> or
> 
> * use an entry in my platform data (next to the reset pin) for the gpio
> number and then try to map this to an irq number?
> 
> or did I miss the best solution?

Probably it makes sense to configure GPIO as input when the
corresponding interrupt is requested from GPIO driver internally.
However, this will require some rework.

Regards, Ilya.

      parent reply	other threads:[~2011-12-20 22:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-29 15:52 [PATCH v2] Touchscreen driver for FT5x06 based EDT displays Simon Budig
2011-09-29 15:52 ` Simon Budig
2011-12-02 13:51   ` Anatolij Gustschin
2011-12-15 11:00     ` Simon Budig
2011-12-15 12:17       ` agust
2011-12-15 13:41         ` Simon Budig
2011-12-16 11:51           ` Anatolij Gustschin
2011-12-20 22:47           ` Ilya Yanok [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EF11083.8050100@emcraft.com \
    --to=yanok@emcraft.com \
    --cc=agust@denx.de \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=simon.budig@kernelconcepts.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.