From mboxrd@z Thu Jan 1 00:00:00 1970 From: Li Zefan Subject: Re: [PATCH 3/5] cgroup: only need to check oldcgrp==newgrp once Date: Wed, 21 Dec 2011 09:29:25 +0800 Message-ID: <4EF13675.9030000@cn.fujitsu.com> References: <1324422873-31001-1-git-send-email-msb@chromium.org> <1324422873-31001-4-git-send-email-msb@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1324422873-31001-4-git-send-email-msb-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Mandeep Singh Baines Cc: Frederic Weisbecker , containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, LKML , Oleg Nesterov , Tejun Heo , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andrew Morton , Paul Menage Mandeep Singh Baines wrote: > In cgroup_attach_proc it is now sufficient to only check that > oldcgrp==newcgrp once. Now that we are using threadgroup_lock() > during the migrations, oldcgrp will not change. > > Signed-off-by: Mandeep Singh Baines Reviewed-by: Li Zefan > Cc: Tejun Heo > Cc: Li Zefan > Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org > Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: KAMEZAWA Hiroyuki > Cc: Frederic Weisbecker > Cc: Oleg Nesterov > Cc: Andrew Morton > Cc: Paul Menage > --- > kernel/cgroup.c | 17 ++++++----------- > 1 files changed, 6 insertions(+), 11 deletions(-) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753698Ab1LUB1d (ORCPT ); Tue, 20 Dec 2011 20:27:33 -0500 Received: from cn.fujitsu.com ([222.73.24.84]:59842 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753067Ab1LUB1b (ORCPT ); Tue, 20 Dec 2011 20:27:31 -0500 Message-ID: <4EF13675.9030000@cn.fujitsu.com> Date: Wed, 21 Dec 2011 09:29:25 +0800 From: Li Zefan User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.9) Gecko/20100921 Fedora/3.1.4-1.fc14 Thunderbird/3.1.4 MIME-Version: 1.0 To: Mandeep Singh Baines CC: Tejun Heo , LKML , Frederic Weisbecker , containers@lists.linux-foundation.org, cgroups@vger.kernel.org, KAMEZAWA Hiroyuki , Oleg Nesterov , Andrew Morton , Paul Menage Subject: Re: [PATCH 3/5] cgroup: only need to check oldcgrp==newgrp once References: <1324422873-31001-1-git-send-email-msb@chromium.org> <1324422873-31001-4-git-send-email-msb@chromium.org> In-Reply-To: <1324422873-31001-4-git-send-email-msb@chromium.org> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.1FP4|July 25, 2010) at 2011-12-21 09:26:34, Serialize by Router on mailserver/fnst(Release 8.5.1FP4|July 25, 2010) at 2011-12-21 09:26:42, Serialize complete at 2011-12-21 09:26:42 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mandeep Singh Baines wrote: > In cgroup_attach_proc it is now sufficient to only check that > oldcgrp==newcgrp once. Now that we are using threadgroup_lock() > during the migrations, oldcgrp will not change. > > Signed-off-by: Mandeep Singh Baines Reviewed-by: Li Zefan > Cc: Tejun Heo > Cc: Li Zefan > Cc: containers@lists.linux-foundation.org > Cc: cgroups@vger.kernel.org > Cc: KAMEZAWA Hiroyuki > Cc: Frederic Weisbecker > Cc: Oleg Nesterov > Cc: Andrew Morton > Cc: Paul Menage > --- > kernel/cgroup.c | 17 ++++++----------- > 1 files changed, 6 insertions(+), 11 deletions(-)