From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
Subject: Re: [PATCH 2/2] kvm tools: Improve './lkvm {pause,resume}'s output
Date: Wed, 21 Dec 2011 17:14:10 +0800
Message-ID: <4EF1A362.4030508@cn.fujitsu.com>
References: <1324454842-28139-1-git-send-email-asias.hejun@gmail.com> <1324454842-28139-2-git-send-email-asias.hejun@gmail.com>
Reply-To: gaowanlong@cn.fujitsu.com
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Pekka Enberg <penberg@kernel.org>,
	Sasha Levin <levinsasha928@gmail.com>,
	Cyrill Gorcunov <gorcunov@gmail.com>,
	Ingo Molnar <mingo@elte.hu>, kvm@vger.kernel.org
To: Asias He <asias.hejun@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from cn.fujitsu.com ([222.73.24.84]:57613 "EHLO song.cn.fujitsu.com"
	rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP
	id S1752363Ab1LUJPX (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 21 Dec 2011 04:15:23 -0500
In-Reply-To: <1324454842-28139-2-git-send-email-asias.hejun@gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 12/21/2011 04:07 PM, Asias He wrote:

> ./lkvm {pause,resume} do not give any feedback to user who uses these
> commands in the console where the command run.
> 
> This patch makes the command output in the command console instead of
> guest console.


I's like notice users in both sides, so don't remove the pr_info?


Thanks
-Wanlong Gao 

> 
> Signed-off-by: Asias He <asias.hejun@gmail.com>
> ---
>  tools/kvm/builtin-pause.c  |    2 ++
>  tools/kvm/builtin-resume.c |    2 ++
>  tools/kvm/builtin-run.c    |    1 -
>  3 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/kvm/builtin-pause.c b/tools/kvm/builtin-pause.c
> index 107641c..a8e805e 100644
> --- a/tools/kvm/builtin-pause.c
> +++ b/tools/kvm/builtin-pause.c
> @@ -54,6 +54,8 @@ static int do_pause(const char *name, int sock)
>  	if (r < 0)
>  		return r;
>  
> +	printf("Guest %s paused\n", name);
> +
>  	return 0;
>  }
>  
> diff --git a/tools/kvm/builtin-resume.c b/tools/kvm/builtin-resume.c
> index 7b87f59..fd00763 100644
> --- a/tools/kvm/builtin-resume.c
> +++ b/tools/kvm/builtin-resume.c
> @@ -54,6 +54,8 @@ static int do_resume(const char *name, int sock)
>  	if (r < 0)
>  		return r;
>  
> +	printf("Guest %s resumed\n", name);
> +
>  	return 0;
>  }
>  
> diff --git a/tools/kvm/builtin-run.c b/tools/kvm/builtin-run.c
> index fac274c..8f512c3 100644
> --- a/tools/kvm/builtin-run.c
> +++ b/tools/kvm/builtin-run.c
> @@ -515,7 +515,6 @@ static void handle_pause(int fd, u32 type, u32 len, u8 *msg)
>  		return;
>  
>  	is_paused = !is_paused;
> -	pr_info("Guest %s\n", is_paused ? "paused" : "resumed");
>  }
>  
>  static void handle_debug(int fd, u32 type, u32 len, u8 *msg)