From: Igor Grinberg <grinberg@compulab.co.il>
To: Ilya Yanok <yanok@emcraft.com>
Cc: linux-omap@vger.kernel.org, sasha_d@emcraft.com
Subject: Re: [PATCH V2 2/2] mcx: support for HTKW mcx board
Date: Wed, 21 Dec 2011 11:19:43 +0200 [thread overview]
Message-ID: <4EF1A4AF.90807@compulab.co.il> (raw)
In-Reply-To: <4EF0EB09.4010008@emcraft.com>
Hi Ilya,
On 12/20/11 22:07, Ilya Yanok wrote:
> Hi Igor,
>
>>> +static struct omap2_hsmmc_info mmc[] = {
>>> + {
>>> + .mmc = 1,
>>> + .caps = MMC_CAP_4_BIT_DATA,
>>> + .gpio_cd = SD_CARD_CD,
>>> + .gpio_wp = SD_CARD_WP,
>>> + .ocr_mask = MMC_VDD_32_33 | MMC_VDD_33_34 |
>>> + MMC_VDD_165_195,
>>
>> The ocr_mask will be overridden, by the following patch:
>> -----------------
>> commit e89715a7e48d505f42813a4e3ee0f0efb49832ba
>> Author: Abhilash K V <abhilash.kv@ti.com>
>> Date: Fri Dec 9 12:27:36 2011 -0800
>>
>> ARM: OMAP: hsmmc: Support for AM3517 MMC1 voltages
>> --------------
>>
>> in Tony's hsmmc branch.
>>
>> IMO it should be fixed, by adding a check if the ocr_mask is
>> already set...
>> I can't send a patch for this right now...
>
> Well, I think I should just drop the .ocr_mask field then. Everything
> works fine for me with the above mentioned patch.
Yes, for your patch, it is correct - just remove it.
My concern is for the common code - it will override any
board special setting (e.g. you want smaller range supported).
>>> +static void __init mcx_init(void)
>>> +{
>>> + int err;
>>> +
>>> + omap3_mux_init(board_mux, OMAP_PACKAGE_CBB);
>>> + mcx_i2c_init();
>>> + platform_add_devices(mcx_devices, ARRAY_SIZE(mcx_devices));
>>> + omap_serial_init();
>>
>> Shouldn't this one be before the mcx_i2c_init() call?
>
> Well, I think I've taken this order from some other board init... I
> think the idea was to bring up regulator chip earlier. But I can move
> serial up with no problem.
I see, no problem.
My "concern" was about the pr_err() inside the mcx_i2c_init()
and the mcx_ts_init() functions.
Also, IMO, mcx_ts_init() can be done at a later stage, than along
with I2C buses initialization, but it does not really meter...
--
Regards,
Igor.
prev parent reply other threads:[~2011-12-21 9:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 0:53 [PATCH V2 0/2] Support for HTKW mcx Ilya Yanok
2011-12-15 0:53 ` [PATCH V2 1/2] mcx: very basic support for HTKW mcx board Ilya Yanok
2011-12-15 9:51 ` Igor Grinberg
2011-12-15 10:17 ` Cousson, Benoit
2011-12-15 10:53 ` Igor Grinberg
2011-12-18 13:21 ` Igor Grinberg
2011-12-15 21:59 ` Ilya Yanok
2011-12-17 1:37 ` Tony Lindgren
2012-01-11 22:03 ` Ilya Yanok
2011-12-15 0:53 ` [PATCH V2 2/2] mcx: " Ilya Yanok
2011-12-15 10:40 ` Igor Grinberg
2011-12-20 20:07 ` Ilya Yanok
2011-12-21 9:19 ` Igor Grinberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF1A4AF.90807@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=linux-omap@vger.kernel.org \
--cc=sasha_d@emcraft.com \
--cc=yanok@emcraft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.