From mboxrd@z Thu Jan  1 00:00:00 1970
From: Aneesh V <aneesh@ti.com>
Date: Wed, 21 Dec 2011 21:25:43 +0530
Subject: [U-Boot] [PATCH 3/3] ARM:AM33XX: Add SPL support for AM335X EVM
In-Reply-To: <CA+M6bX=zpYBhaWA21GKUDBDvjTDo3+RTa==OpnUVhfpdOWyNpA@mail.gmail.com>
References: <1324472601-1142-1-git-send-email-chandan.nath@ti.com>	<1324472601-1142-4-git-send-email-chandan.nath@ti.com>
	<CA+M6bX=zpYBhaWA21GKUDBDvjTDo3+RTa==OpnUVhfpdOWyNpA@mail.gmail.com>
Message-ID: <4EF2017F.3020003@ti.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Wednesday 21 December 2011 09:16 PM, Tom Rini wrote:
> On Wed, Dec 21, 2011 at 6:03 AM, Chandan Nath<chandan.nath@ti.com>  wrote:
>> This patch is added to support SPL feature on AM335X
>> platform. In this patch, MMC1 is configured as boot
>> device for SPL and support for other devices will be
>> added in the next patch series.
> [snip]
>> +#ifdef CONFIG_SPL_BUILD
>> +u32 am33xx_boot_device = BOOT_DEVICE_MMC1;
>
> Please see the Overo SPL thread where Wolfgang mentions the right way
> to init this to 0 and have it be in the data section, followed by me
> saying I'd see if<linux/compiler.h>  had a shortcut.

But here looks like he doesn't intend to initialize it to 0?

>
>> +u32 omap_boot_mode(void)
>> +{
>
> Something I wanted to see, but hadn't had a chance to look into was if
> we could use the OMAP4/5 code for boot_mode as well, can you please
> check?
>

OMAP4/5 code parses ROM code structures (using a pointer passed by ROM
code). If those structures and their layout are exactly same in AM33XX,
it may work, otherwise it won't.

br,
Aneesh